'Review Request: Plasmate:mainwindow::closeProject() works correctly'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Plasmate:mainwindow::closeProject() works correctly
From:       "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date:       2011-07-24 20:58:27
Message-ID: 20110724205827.4338.51627 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102078/
-----------------------------------------------------------

Review request for Plasma.

Summary
-------

hello,

create a new project using plasmate and then go to File->Close Project.
You will see the bug(look at the screenshot),this patch fixes the issue and=
 also makes the m_docbrowser to call hide() instead of setVisible(false).

Diffs
-----

  mainwindow.cpp 3dbdefc =

  startpage.h 6d45e02 =

Diff: http://git.reviewboard.kde.org/r/102078/diff

Testing
-------

compiles and runs fine

Screenshots
-----------

  http://git.reviewboard.kde.org/r/102078/s/211/

Thanks,

Giorgos

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102078/">http://git.reviewboard.kde.org/r/102078/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hello,

create a new project using plasmate and then go to File-&gt;Close Project.
You will see the bug(look at the screenshot),this patch fixes the issue and also \
makes the m_docbrowser to call hide() instead of setVisible(false).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles and runs fine</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>mainwindow.cpp <span style="color: grey">(3dbdefc)</span></li>

 <li>startpage.h <span style="color: grey">(6d45e02)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102078/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/102078/s/211/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/07/24/snapshot1_1_400x100.png" \
style="border: 1px black solid;" alt="" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 