This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101916/

On July 11th, 2011, 6:27 p.m., Giorgos Tsiapaliwkas wrote:

projectmanager/projectmanager.cpp (Diff revision 1)
ProjectManager::ProjectManager(QWidget* parent)
73
ProjectManager::~ProjectManager()
74
{
75
    delete m_projectList;
76
    delete m_loadButton;
77
    delete m_removeMenu;
78
    delete m_removeMenuButton;
79
}
Why in general the destructors of plasmate doesn't do something like that??

On July 12th, 2011, 3 p.m., Aaron J. Seigo wrote:

the more typical approach is to parent those items to something and let QObject handle it.

e.g. this:

m_loadButton = new KPushButton(i18n("Load Project"));

should become this:

m_loadButton = new KPushButton(i18n("Load Project"), this);

there's no need for a dtor then.

On July 13th, 2011, 2:58 p.m., Giorgos Tsiapaliwkas wrote:

so,i will replace evething that is necessary with the "this".
Is that ok??
yep, that should work fine... parent the widgets and then commit :)

- Aaron J.


On July 11th, 2011, 6:12 p.m., Giorgos Tsiapaliwkas wrote:

Review request for Plasma.
By Giorgos Tsiapaliwkas.

Updated July 11, 2011, 6:12 p.m.

Description

hello,

I was looking at the projectmanager.projectmanager.[h/cpp] and i noticed that there wasn't no destructor.
The patch adds a destructor at projectmanager and changed a bit the mainwindow.cpp.

I have some question in my next reply

Testing

compiles fine and no pointer error

Diffs

  • mainwindow.cpp (e08581f)
  • projectmanager/projectmanager.h (53ef226)
  • projectmanager/projectmanager.cpp (122e48d)

View Diff