From kde-panel-devel Tue Jul 19 19:12:40 2011 From: "Commit Hook" Date: Tue, 19 Jul 2011 19:12:40 +0000 To: kde-panel-devel Subject: Re: Review Request: Be sure that Panel is resized when needed (XRandR Message-Id: <20110719191240.4109.26396 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=131110282417299 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0227180697==" --===============0227180697== Content-Type: multipart/alternative; boundary="===============0259963899050081550==" --===============0259963899050081550== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101968/#review4865 ----------------------------------------------------------- This review has been submitted with commit 9e66958635a7786d3896e3ad6a8aa8b0= 621f046b by Alex Fiestas to branch KDE/4.7. - Commit On July 16, 2011, 1:34 p.m., Alex Fiestas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101968/ > ----------------------------------------------------------- > = > (Updated July 16, 2011, 1:34 p.m.) > = > = > Review request for Plasma and Aaron J. Seigo. > = > = > Summary > ------- > = > The bug can be reproduce: > 1-kill plasma > 2-Remove all screens leaving only the smaller one > 3-Launch plasma > 4-Add a new bigger screen > = > The panel will have the old size but will be placed in the right place. > = > The bug seems to be in the if/elseif block's that check conditions suck "= The old screen was smaller, checking...". The first conditional block is to= know if the config has to be saved, if the config has to be saved then non= e of the checks will be perform since they're in else if, so the panel won'= t be resized. > = > = > Diffs > ----- > = > plasma/desktop/shell/panelview.cpp e31c06d = > = > Diff: http://git.reviewboard.kde.org/r/101968/diff > = > = > Testing > ------- > = > I have been messing around for 1h including vertical panels, so far so go= od. > = > = > Thanks, > = > Alex > = > --===============0259963899050081550== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101968/ 

This revie=
w has been submitted with commit 9e66958635a7786d3896e3ad6a8aa8b0621f046b b=
y Alex Fiestas to branch KDE/4.7.

- Commit


On July 16th, 2011, 1:34 p.m., Alex Fiestas wrote:

Review request for Plasma and Aaron J. Seigo.
By Alex Fiestas.

Updated July 16, 2011, 1:34 p.m.

Descripti= on 

The bug can be reproduce:
1-kill plasma
2-Remove all screens leaving only the smaller one
3-Launch plasma
4-Add a new bigger screen

The panel will have the old size but will be placed in the right place.

The bug seems to be in the if/elseif block's that check conditions suck=
 "The old screen was smaller, checking...". The first conditional=
 block is to know if the config has to be saved, if the config has to be sa=
ved then none of the checks will be perform since they're in else if, s=
o the panel won't be resized.

Testing <= /h1> 
I have been messing around for 1h including vertical panels,=
 so far so good.

Diffs=

  • plasma/desktop/shell/panelview.cpp (e31c06= d)

View Diff
--===============0259963899050081550==-- --===============0227180697== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0227180697==--