'Review Request: Be sure that Panel is resized when needed (XRandR'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Be sure that Panel is resized when needed (XRandR
From:       "Alex Fiestas" <alex () eyeos ! org>
Date:       2011-07-16 13:34:25
Message-ID: 20110716133425.24022.18379 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101968/
-----------------------------------------------------------

Review request for Plasma and Aaron J. Seigo.

Summary
-------

The bug can be reproduce:
1-kill plasma
2-Remove all screens leaving only the smaller one
3-Launch plasma
4-Add a new bigger screen

The panel will have the old size but will be placed in the right place.

The bug seems to be in the if/elseif block's that check conditions suck "Th=
e old screen was smaller, checking...". The first conditional block is to k=
now if the config has to be saved, if the config has to be saved then none =
of the checks will be perform since they're in else if, so the panel won't =
be resized.

Diffs
-----

  plasma/desktop/shell/panelview.cpp e31c06d =

Diff: http://git.reviewboard.kde.org/r/101968/diff

Testing
-------

I have been messing around for 1h including vertical panels, so far so good.

Thanks,

Alex

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101968/">http://git.reviewboard.kde.org/r/101968/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Alex Fiestas.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The bug can be reproduce: 1-kill plasma
2-Remove all screens leaving only the smaller one
3-Launch plasma
4-Add a new bigger screen

The panel will have the old size but will be placed in the right place.

The bug seems to be in the if/elseif block&#39;s that check conditions suck &quot;The \
old screen was smaller, checking...&quot;. The first conditional block is to know if \
the config has to be saved, if the config has to be saved then none of the checks \
will be perform since they&#39;re in else if, so the panel won&#39;t be \
resized.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have been messing around for 1h including vertical panels, so far so \
good.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/shell/panelview.cpp <span style="color: \
grey">(e31c06d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101968/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 