'Review Request: Plasmate:add a destructor and some changes to the'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Plasmate:add a destructor and some changes to the
From:       "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date:       2011-07-11 18:12:20
Message-ID: 20110711181220.23983.41494 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101916/
-----------------------------------------------------------

Review request for Plasma.

Summary
-------

hello,

I was looking at the projectmanager.projectmanager.[h/cpp] and i noticed th=
at there wasn't no destructor.
The patch adds a destructor at projectmanager and changed a bit the mainwin=
dow.cpp.

I have some question in my next reply

Diffs
-----

  mainwindow.cpp e08581f =

  projectmanager/projectmanager.h 53ef226 =

  projectmanager/projectmanager.cpp 122e48d =

Diff: http://git.reviewboard.kde.org/r/101916/diff

Testing
-------

compiles fine and no pointer error

Thanks,

Giorgos

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101916/">http://git.reviewboard.kde.org/r/101916/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hello,

I was looking at the projectmanager.projectmanager.[h/cpp] and i noticed that there \
wasn&#39;t no destructor. The patch adds a destructor at projectmanager and changed a \
bit the mainwindow.cpp.

I have some question in my next reply</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles fine and no pointer error</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>mainwindow.cpp <span style="color: grey">(e08581f)</span></li>

 <li>projectmanager/projectmanager.h <span style="color: grey">(53ef226)</span></li>

 <li>projectmanager/projectmanager.cpp <span style="color: \
grey">(122e48d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101916/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 