[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate:make plasmate remember the last checked
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-07-06 13:19:04
Message-ID: 20110706131904.17765.65952 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 3, 2011, 6:37 p.m., Giorgos Tsiapaliwkas wrote:
> > After Aaron's patches,the qdockwidgets are working completly differentl=
y so this patch is useless.
> > However,how would you like the plasmate to handle the qdockwidgets?
> > Do you want to rewrite this patch?
> > If yes,which dockwidgets do you want to be visible at the first time th=
at someone creates a project?
no, my fixes make this patch redundant, actually.
the dockwidets which are visible the first time are the file list and the p=
reviewer (if any), and this is also implemented now.
so i consider this "done" ...
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101582/#review4356
-----------------------------------------------------------
On June 18, 2011, 6:30 p.m., Giorgos Tsiapaliwkas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101582/
> -----------------------------------------------------------
> =
> (Updated June 18, 2011, 6:30 p.m.)
> =
> =
> Review request for Plasma and Aaron J. Seigo.
> =
> =
> Summary
> -------
> =
> hello,
> =
> since now plasmate wasn't able to remember the last used qdockwidgets,exc=
ept from 1 or 2.
> With this patch,it (plasmate) is able to remember the last state of the q=
dockwidgets and also the size of the mainwindow (maximized or not).
> The drawback is that when the plasmate will start for the first time it w=
ill be a bit too populated since all the qdockwidgets will be checked.
> =
> =
> Diffs
> -----
> =
> mainwindow.cpp 8326a29 =
> startpage.cpp 3d5f765 =
> =
> Diff: http://git.reviewboard.kde.org/r/101582/diff
> =
> =
> Testing
> -------
> =
> compiles fine without issues and regressions.
> =
> =
> Thanks,
> =
> Giorgos
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101582/">http://git.reviewboard.kde.org/r/101582/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 3rd, 2011, 6:37 p.m., <b>Giorgos \
Tsiapaliwkas</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After Aaron's patches,the qdockwidgets are working completly \
differently so this patch is useless. However,how would you like the plasmate to \
handle the qdockwidgets? Do you want to rewrite this patch?
If yes,which dockwidgets do you want to be visible at the first time that someone \
creates a project?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no, my fixes make this \
patch redundant, actually.
the dockwidets which are visible the first time are the file list and the previewer \
(if any), and this is also implemented now.
so i consider this "done" ...</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On June 18th, 2011, 6:30 p.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated June 18, 2011, 6:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hello,
since now plasmate wasn't able to remember the last used qdockwidgets,except from \
1 or 2. With this patch,it (plasmate) is able to remember the last state of the \
qdockwidgets and also the size of the mainwindow (maximized or not). The drawback is \
that when the plasmate will start for the first time it will be a bit too populated \
since all the qdockwidgets will be checked.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles fine without issues and regressions.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mainwindow.cpp <span style="color: grey">(8326a29)</span></li>
<li>startpage.cpp <span style="color: grey">(3d5f765)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101582/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic