From kde-panel-devel Wed Jun 29 11:53:39 2011 From: "Commit Hook" Date: Wed, 29 Jun 2011 11:53:39 +0000 To: kde-panel-devel Subject: Re: Review Request: plasma-windowed: Quit on closeEvent not on Message-Id: <20110629115339.2848.32491 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=130934844915821 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1777744157==" --===============1777744157== Content-Type: multipart/alternative; boundary="===============2050897575444113827==" --===============2050897575444113827== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101802/#review4257 ----------------------------------------------------------- This review has been submitted with commit 3c51bdc87e1a05560b3a3eb58c8ba909= f8a27166 by David Palacio to branch KDE/4.7. - Commit On June 29, 2011, 2:19 a.m., David Palacio wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101802/ > ----------------------------------------------------------- > = > (Updated June 29, 2011, 2:19 a.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > The view deletes itself when a hideEvent (QWidget) is sent. This is wrong= as minimization and desktop switches send this kind of event. > = > = > This addresses bug 253153. > http://bugs.kde.org/show_bug.cgi?id=3D253153 > = > = > Diffs > ----- > = > plasma/generic/shells/plasma-windowed/singleview.h ba9e767 = > plasma/generic/shells/plasma-windowed/singleview.cpp da87cf8 = > = > Diff: http://git.reviewboard.kde.org/r/101802/diff > = > = > Testing > ------- > = > Tested on KDE 4.6. > = > = > Thanks, > = > David > = > --===============2050897575444113827== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101802/ 

This revie=
w has been submitted with commit 3c51bdc87e1a05560b3a3eb58c8ba909f8a27166 b=
y David Palacio to branch KDE/4.7.

- Commit


On June 29th, 2011, 2:19 a.m., David Palacio wrote:

Review request for Plasma.
By David Palacio.

Updated June 29, 2011, 2:19 a.m.

Descripti= on 

The view deletes itself when a hideEvent (QWidget) is sent. =
This is wrong as minimization and desktop switches send this kind of event.=

Testing <= /h1> 
Tested on KDE 4.6.
Bugs: 253153

Diffs=

  • plasma/generic/shells/plasma-windowed/singleview.h (ba9e767)
  • plasma/generic/shells/plasma-windowed/singleview.cpp (da87cf8)

View Diff
--===============2050897575444113827==-- --===============1777744157== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1777744157==--