[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: plasma-windowed: Quit on closeEvent not on
From: "David Palacio" <dpalacio () orbitalibre ! org>
Date: 2011-06-29 2:26:45
Message-ID: 20110629022645.12326.25691 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101802/#review4239
-----------------------------------------------------------
plasma/generic/shells/plasma-windowed/singleview.cpp
<http://git.reviewboard.kde.org/r/101802/#comment3478>
I think the deleteLater() call should stay. Maybe after \
QGraphicsView::closeEvent()?
- David
On June 29, 2011, 2:19 a.m., David Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101802/
> -----------------------------------------------------------
>
> (Updated June 29, 2011, 2:19 a.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> The view deletes itself when a hideEvent (QWidget) is sent. This is wrong as \
> minimization and desktop switches send this kind of event.
>
> This addresses bug 253153.
> http://bugs.kde.org/show_bug.cgi?id=253153
>
>
> Diffs
> -----
>
> plasma/generic/shells/plasma-windowed/singleview.h ba9e767
> plasma/generic/shells/plasma-windowed/singleview.cpp da87cf8
>
> Diff: http://git.reviewboard.kde.org/r/101802/diff
>
>
> Testing
> -------
>
> Tested on KDE 4.6.
>
>
> Thanks,
>
> David
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101802/">http://git.reviewboard.kde.org/r/101802/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101802/diff/1/?file=25708#file25708line117" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/shells/plasma-windowed/singleview.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
SingleView::resizeEvent(QResizeEvent *event)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">117</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">deleteLater</span><span class="p">();</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">116</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QGraphicsView</span><span class="o">::</span><span \
class="n">closeEvent</span><span class="p">(</span><span class="n">event</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the \
deleteLater() call should stay. Maybe after QGraphicsView::closeEvent()?</pre> </div>
<br />
<p>- David</p>
<br />
<p>On June 29th, 2011, 2:19 a.m., David Palacio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Palacio.</div>
<p style="color: grey;"><i>Updated June 29, 2011, 2:19 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The view deletes itself when a hideEvent (QWidget) is sent. This is \
wrong as minimization and desktop switches send this kind of event.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on KDE 4.6.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=253153">253153</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/shells/plasma-windowed/singleview.h <span style="color: \
grey">(ba9e767)</span></li>
<li>plasma/generic/shells/plasma-windowed/singleview.cpp <span style="color: \
grey">(da87cf8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101802/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic