[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Remove Mouse Emulation from KWin
From: "Commit Hook" <null () kde ! org>
Date: 2011-06-23 10:01:15
Message-ID: 20110623100115.3855.66294 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101406/#review4091
-----------------------------------------------------------
This review has been submitted with commit 2a6bb04ba01804c9917d29c5d55e1228=
acb544c2 by Martin Gr=C3=A4=C3=9Flin to branch master.
- Commit
On May 21, 2011, 6:56 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101406/
> -----------------------------------------------------------
> =
> (Updated May 21, 2011, 6:56 a.m.)
> =
> =
> Review request for kwin and Plasma.
> =
> =
> Summary
> -------
> =
> Mouse Emulation is provided in a better way by KAccess. This provides a g=
lobal systemsettings switch to enable mouse emulation instead of a shortcut=
and Xkb to enable mouse control with keyboard instead of sending out fake =
mouse events.
> =
> So no need for duplicated functionality in KWin.
> =
> =
> Feature for "when master opens up again"
> =
> =
> Diffs
> -----
> =
> kwin/events.cpp 66a9419 =
> kwin/kwinbindings.cpp 06ed2e8 =
> kwin/workspace.h 837e557 =
> kwin/workspace.cpp cb73cc9 =
> =
> Diff: http://git.reviewboard.kde.org/r/101406/diff
> =
> =
> Testing
> -------
> =
> KWin compiles and starts
> =
> =
> Thanks,
> =
> Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101406/">http://git.reviewboard.kde.org/r/101406/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 2a6bb04ba01804c9917d29c5d55e1228acb544c2 by Martin Gräßlin to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On May 21st, 2011, 6:56 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated May 21, 2011, 6:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Mouse Emulation is provided in a better way by KAccess. This provides a \
global systemsettings switch to enable mouse emulation instead of a shortcut and Xkb \
to enable mouse control with keyboard instead of sending out fake mouse events.
So no need for duplicated functionality in KWin.
Feature for "when master opens up again"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KWin compiles and starts</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/events.cpp <span style="color: grey">(66a9419)</span></li>
<li>kwin/kwinbindings.cpp <span style="color: grey">(06ed2e8)</span></li>
<li>kwin/workspace.h <span style="color: grey">(837e557)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(cb73cc9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101406/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic