'Re: Review Request: Fix possible memory and D-Bus connection leak in'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix possible memory and D-Bus connection leak in
From:       "Commit Hook" <null () kde ! org>
Date:       2011-06-20 10:07:03
Message-ID: 20110620100703.24593.77557 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101527/#review4044
-----------------------------------------------------------

This review has been submitted with commit d6cc53cd80e326bfea9382b475977e0184a4223b \
by Aaron Seigo to branch master.

- Commit

On June 6, 2011, 3:31 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101527/
> -----------------------------------------------------------
> 
> (Updated June 6, 2011, 3:31 p.m.)
> 
> 
> Review request for kdelibs, Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> According to bug 261180 there is a D-Bus connection leak in KStatusNotifierItem. \
> This patch potentially fixes it, but I do not know how to test it. 
> 
> This addresses bug 261180.
> http://bugs.kde.org/show_bug.cgi?id=261180
> 
> 
> Diffs
> -----
> 
> kdeui/notifications/kstatusnotifieritem.cpp c48ed50 
> 
> Diff: http://git.reviewboard.kde.org/r/101527/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101527/">http://git.reviewboard.kde.org/r/101527/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit d6cc53cd80e326bfea9382b475977e0184a4223b by Aaron Seigo to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On June 6th, 2011, 3:31 p.m., Christoph Feck wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs, Plasma and Marco Martin.</div>
<div>By Christoph Feck.</div>

<p style="color: grey;"><i>Updated June 6, 2011, 3:31 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">According to bug 261180 there is a D-Bus connection leak in \
KStatusNotifierItem. This patch potentially fixes it, but I do not know how to test \
it.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=261180">261180</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdeui/notifications/kstatusnotifieritem.cpp <span style="color: \
grey">(c48ed50)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101527/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 