--===============0805800563== Content-Type: multipart/alternative; boundary="===============2537737420453858851==" --===============2537737420453858851== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101584/#review4041 ----------------------------------------------------------- see my comment on the other review request. in fact, i'm going to close thi= s one in favor of the other one. projectmanager/projectmanager.cpp spaces after commas :) projectmanager/projectmanager.cpp looks like this isn't properly aligned? projectmanager/projectmanager.cpp watch indentation! projectmanager/projectmanager.cpp preferable this should become: = if (code =3D=3D KMessageBox::Continue) { removeProcess(); } = projectmanager/projectmanager.cpp if ( - Aaron J. On June 11, 2011, 4:38 p.m., Giorgos Tsiapaliwkas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101584/ > ----------------------------------------------------------- > = > (Updated June 11, 2011, 4:38 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > hello, > = > the need for the patch is coming from this todo "TODO: should perform a s= uccess check here instead of assuming success." > The patch shares some code with this one ( git.reviewboard.kde.org/r/1015= 35/). > = > = > Diffs > ----- > = > projectmanager/projectmanager.h 2c5bff2 = > projectmanager/projectmanager.cpp c00fd27 = > = > Diff: http://git.reviewboard.kde.org/r/101584/diff > = > = > Testing > ------- > = > compiles without issues.tested be my > = > = > Thanks, > = > Giorgos > = > --===============2537737420453858851== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101584/

see my com=
ment on the other review request. in fact, i'm going to close this one =
in favor of the other one.

= =

projectmanager/projectmanager.cpp (Diff revision 2)
ProjectManager::ProjectManager(QWidget* parent) : QDialog(parent)
		52	connect(removeFromDiskButton,SIGNAL(clicked()),thi= s,SLOT(confirmRemoveFromDisk() ));

spaces after commas :)

= =

projectmanager/projectmanager.cpp (Diff revision 2)
ProjectManager::ProjectManager(QWidget* parent) : QDialog(parent)
53	hoz->addWidget(deleteButton);	56	hoz->addWidget(= removeFromListButton);

looks like this isn't properly aligned?

= =

projectmanager/projectmanager.cpp (Diff revision 2)
	void ProjectManager::confirmRemoveFromDisk()
		77	int code =3D KMessageB= ox::warningContinueCancel= (this, dialogText);

watch indentation!

= =

projectmanager/projectmanager.cpp (Diff revision 2)
	void ProjectManager::confirmRemoveFromDisk()
		78	if (code !=3D KMessageBox::Continue) return;

preferable this should become:

if (code =3D=3D KMessageBox::Continue) {
    removeProcess();
}

= =

projectmanager/projectmanager.cpp (Diff revision 2)
	void ProjectManager::confirmRemoveFromDisk()
		94	if(destroyFlag()) {

if (

- Aaron J.

On June 11th, 2011, 4:38 p.m., Giorgos Tsiapaliwkas wrote:

Review request for Plasma.

By Giorgos Tsiapaliwkas.

Updated June 11, 2011, 4:38 p.m.

Descripti= on

hello,

the need for the patch is coming from this todo "TODO: should perform =
a success check here instead of assuming success."
The patch shares some code with this one ( git.reviewboard.kde.org/r/101535=
/).

Testing <= /h1>

compiles without issues.tested be my

Diffs=

projectmanager/projectmanager.h (2c5bff2)<= /span>
projectmanager/projectmanager.cpp (c00fd27= )

--===============2537737420453858851==-- --===============0805800563== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0805800563==--