This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101584/

see my comment on the other review request. in fact, i'm going to close this one in favor of the other one.

projectmanager/projectmanager.cpp (Diff revision 2)
ProjectManager::ProjectManager(QWidget* parent) : QDialog(parent)
		52	connect(removeFromDiskButton,SIGNAL(clicked()),this,SLOT(confirmRemoveFromDisk() ));

spaces after commas :)

projectmanager/projectmanager.cpp (Diff revision 2)
ProjectManager::ProjectManager(QWidget* parent) : QDialog(parent)
53	hoz->addWidget(deleteButton);	56	hoz->addWidget(removeFromListButton);

looks like this isn't properly aligned?

projectmanager/projectmanager.cpp (Diff revision 2)
		void ProjectManager::confirmRemoveFromDisk()
		77	int code = KMessageBox::warningContinueCancel(this, dialogText);

watch indentation!

projectmanager/projectmanager.cpp (Diff revision 2)
		void ProjectManager::confirmRemoveFromDisk()
		78	if (code != KMessageBox::Continue) return;

preferable this should become:

if (code == KMessageBox::Continue) {
    removeProcess();
}

projectmanager/projectmanager.cpp (Diff revision 2)
		void ProjectManager::confirmRemoveFromDisk()
		94	if(destroyFlag()) {

if (

- Aaron J.

On June 11th, 2011, 4:38 p.m., Giorgos Tsiapaliwkas wrote:

Review request for Plasma.

By Giorgos Tsiapaliwkas.

Updated June 11, 2011, 4:38 p.m.

Description

hello,

the need for the patch is coming from this todo "TODO: should perform a success check here instead of assuming success."
The patch shares some code with this one ( git.reviewboard.kde.org/r/101535/).

Testing

compiles without issues.tested be my

Diffs

projectmanager/projectmanager.h (2c5bff2)
projectmanager/projectmanager.cpp (c00fd27)

View Diff