this patch didn't get uploaded fully; please re-submit. the part that did get submitted is full of crashes, however.
|
mainwindow.cpp
(Diff revision 3)
|
void MainWindow::loadProject(const QString &name, const QString &type) |
|
|
682 |
m_previewerWidget->setVisible(false); |
the check in the if statement above means that in this else, m_previewerWidget is NULL and so this will crash!
|
mainwindow.cpp
(Diff revision 3)
|
void MainWindow::loadProject(const QString &name, const QString &type) |
|
|
686 |
setNotesVisible(true); |
isn't this duplicated with the code that immediately follows?
|
mainwindow.cpp
(Diff revision 3)
|
void MainWindow::loadProject(const QString &name, const QString &type) |
|
|
687 |
if (m_notesWidget) { |
|
|
688 |
setNotesVisible(true); |
|
|
689 |
} else { |
|
|
690 |
setNotesVisible(false); |
|
|
691 |
} |
simpler as:
setNotesVisible(m_notesWidget);
|
mainwindow.cpp
(Diff revision 3)
|
void MainWindow::loadProject(const QString &name, const QString &type) |
|
|
698 |
m_timeLine->setVisible(false); |
crash.
|
mainwindow.cpp
(Diff revision 3)
|
void MainWindow::loadProject(const QString &name, const QString &type) |
|
|
706 |
m_browser->setVisible(false); |
crash.
|
mainwindow.cpp
(Diff revision 3)
|
void MainWindow::loadProject(const QString &name, const QString &type) |
| 683 |
setFileListVisible(true); |
710 |
setFileListVisible(true); |
|
|
711 |
if (m_editWidget) { |
|
|
712 |
setFileListVisible(true); |
|
|
713 |
} else { |
|
|
714 |
setFileListVisible(false); |
|
|
715 |
} |
seems highly duplicated and could simply be setFileListVisible(m_editWidget)
- Aaron J.
On June 18th, 2011, 6:30 p.m., Giorgos Tsiapaliwkas wrote:
|
Review request for Plasma and Aaron J. Seigo.
By Giorgos Tsiapaliwkas.
Updated June 18, 2011, 6:30 p.m.
Description
hello,
since now plasmate wasn't able to remember the last used qdockwidgets,except from 1 or 2.
With this patch,it (plasmate) is able to remember the last state of the qdockwidgets and also the size of the mainwindow (maximized or not).
The drawback is that when the plasmate will start for the first time it will be a bit too populated since all the qdockwidgets will be checked.
|
Testing
compiles fine without issues and regressions.
|
Diffs
- mainwindow.cpp (8326a29)
- startpage.cpp (3d5f765)
View Diff
|