From kde-panel-devel Mon Jun 20 10:04:05 2011 From: "Aaron J. Seigo" Date: Mon, 20 Jun 2011 10:04:05 +0000 To: kde-panel-devel Subject: Re: Review Request: Plasmate:make plasmate remember the last checked Message-Id: <20110620100405.24445.33424 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=130856428809632 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0081078074==" --===============0081078074== Content-Type: multipart/alternative; boundary="===============6357441355758497029==" --===============6357441355758497029== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101582/#review4043 ----------------------------------------------------------- this patch didn't get uploaded fully; please re-submit. the part that did g= et submitted is full of crashes, however. mainwindow.cpp the check in the if statement above means that in this else, m_previewe= rWidget is NULL and so this will crash! mainwindow.cpp isn't this duplicated with the code that immediately follows? mainwindow.cpp simpler as: = setNotesVisible(m_notesWidget); mainwindow.cpp crash. mainwindow.cpp crash. mainwindow.cpp seems highly duplicated and could simply be setFileListVisible(m_editWi= dget) - Aaron J. On June 18, 2011, 6:30 p.m., Giorgos Tsiapaliwkas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101582/ > ----------------------------------------------------------- > = > (Updated June 18, 2011, 6:30 p.m.) > = > = > Review request for Plasma and Aaron J. Seigo. > = > = > Summary > ------- > = > hello, > = > since now plasmate wasn't able to remember the last used qdockwidgets,exc= ept from 1 or 2. > With this patch,it (plasmate) is able to remember the last state of the q= dockwidgets and also the size of the mainwindow (maximized or not). > The drawback is that when the plasmate will start for the first time it w= ill be a bit too populated since all the qdockwidgets will be checked. > = > = > Diffs > ----- > = > mainwindow.cpp 8326a29 = > startpage.cpp 3d5f765 = > = > Diff: http://git.reviewboard.kde.org/r/101582/diff > = > = > Testing > ------- > = > compiles fine without issues and regressions. > = > = > Thanks, > = > Giorgos > = > --===============6357441355758497029== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101582/

this patch=
 didn't get uploaded fully; please re-submit. the part that did get sub=
mitted is full of crashes, however.

= =

mainwindow.cpp (Diff revision 3)
void MainWindow::loadProject(const QString &name, const QString= &type)
		682	m_previewerWidget->setVisible(false);

the check in the if statement above means that in this else, m_previ=
ewerWidget is NULL and so this will crash!

= =

mainwindow.cpp (Diff revision 3)
void MainWindow::loadProject(const QString &name, const QString= &type)
		686	setNotesVisible(true);<= /span>

isn't this duplicated with the code that immediately follows?

= =

mainwindow.cpp (Diff revision 3)
void MainWindow::loadProject(const QString &name, const QString= &type)
		687	if (m_notesWidget) {
		688	setNotesVisible(true);
		689	} else {
		690	setNotesVisible(false);
		691	}

simpler as:

setNotesVisible(m_notesWidget);

= =

mainwindow.cpp (Diff revision 3)
void MainWindow::loadProject(const QString &name, const QString= &type)
		698	m_timeLine->setVisible(false);

crash.

= =

mainwindow.cpp (Diff revision 3)
void MainWindow::loadProject(const QString &name, const QString= &type)
		706	m_browser->setVisible(false);

crash.

= = = =

mainwindow.cpp (Diff revision 3)
void MainWindow::loadProject(const QString &name, const QString= &type)
683	setFileListVisible(true= );	710	setFileListVisible(true= );
		711	if (m_editWidget)= {
		712	setFileListVisible(true);
		713	} else {
		714	setFileListVisible(false);
		715	}

seems highly duplicated and could simply be setFileListVisible(m_edi=
tWidget)

- Aaron J.

On June 18th, 2011, 6:30 p.m., Giorgos Tsiapaliwkas wrote:

Review request for Plasma and Aaron J. Seigo.

By Giorgos Tsiapaliwkas.

Updated June 18, 2011, 6:30 p.m.

Descripti= on

hello,

since now plasmate wasn't able to remember the last used qdockwidgets,e=
xcept from 1 or 2.
With this patch,it (plasmate) is able to remember the last state of the qdo=
ckwidgets and also the size of the mainwindow (maximized or not).
The drawback is that when the plasmate will start for the first time it wil=
l be a bit too populated since all the qdockwidgets will be checked.

Testing <= /h1>

compiles fine without issues and regressions.

Diffs=

mainwindow.cpp (8326a29)
startpage.cpp (3d5f765)

--===============6357441355758497029==-- --===============0081078074== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0081078074==--