This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101535/

= = = = = = = = = =

projectmanager/projectmanager.cpp (Diff revision 4)
void ProjectManager::confirmDeletion()
61	void ProjectManager::confir= mDeletion() =	65	void ProjectManager::confir= mRemoveFromList()=
62	{	66	{
63	//TODO: might want to disallow deleting a curr= ently active project, or handle it	67	//TODO: might want to disallow deleting a curr= ently active project, or handle it
64	// gracefully some= how.	68	// gracefully some= how.
65	QString dialogText =3D i= 18n("Are you sure yo= u want to delete the selected projects? This cann= ot be undone.");	69	QString dialogText =3D i= 18n("Are you sure yo= u want to remove the selected projects from the list? This cannot be undone.");
66	int code =3D KMessageB= ox::warningContinueCancel= (this, dialogText);	70	int code =3D KMessageB= ox::warningContinueCancel= (this, dialogText);
67	if (code !=3D KMessageBox::Continue) return;	71	if (code !=3D KMessageBox::Continue) return;
		72	removeProcess();
		73	}

this is buggy. if confirmRemoveFromDisk is called first and then lat=
er confirmRemoveFromList is called ... m_destroyFlag will still be true and=
 the project will not just be removed from the list, but also disk!

instead, i recommend changing removeProcess to take a bool and change the n=
ame to something more accurate about the method's job, e.g.: removeProj=
ect(bool deleteFiles). then call it directly from both places, so in confir=
mRemoveFromList we'd get:

if (KMessageBox::warningContinueCancel(this, dialogText) =3D=3D KMessageBox=
::Continue) {
    removeProject(false);
}

and in confirmRemoveFromDisk:

if (KMessageBox::warningContinueCancel(this, dialogText) =3D=3D KMessageBox=
::Continue) {
    removeProject(true);
}

- Aaron J.

On June 10th, 2011, 9 p.m., Giorgos Tsiapaliwkas wrote:

Review request for Plasma.

By Giorgos Tsiapaliwkas.

Updated June 10, 2011, 9 p.m.

Descripti= on

Hello,

after a discussion with Aaron Seigo at the #plasma we decided to add a new =
button at the project manager which is named "Remove Project From List=
",which deletes the project only from the list(not from disk).The dele=
te button was renamed to "Remove Project From Disk".Also i consid=
er it properly to change the names of some function in order to be more rel=
ative with the buttons names.As well i changed and the functionality of con=
firmdeletion() in order to avoid using the same code twice.

Testing <= /h1>

compiles and runs without regressions.
tested by me.

Diffs=

projectmanager/projectmanager.h (2c5bff2)<= /span>
projectmanager/projectmanager.cpp (c00fd27= )

View Diff

Descripti= on

Testing <= /h1> compiles and runs without regressions. tested by me.

Diffs=

Testing <= /h1>

compiles and runs without regressions. tested by me.