From kde-panel-devel Mon Jun 20 09:53:42 2011 From: "Aaron J. Seigo" Date: Mon, 20 Jun 2011 09:53:42 +0000 To: kde-panel-devel Subject: Re: Review Request: Plasmate:void ProjectManager::removeDirectory Message-Id: <20110620095342.22513.78304 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=130856368208942 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1588964573==" --===============1588964573== Content-Type: multipart/alternative; boundary="===============6981142963581860824==" --===============6981142963581860824== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101550/#review4040 ----------------------------------------------------------- projectmanager/projectmanager.cpp please use KIO::del here (defined in KIO/DeleteJob) = it simplifies everything and uses KIO as it should be... - Aaron J. On June 8, 2011, 9:51 p.m., Giorgos Tsiapaliwkas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101550/ > ----------------------------------------------------------- > = > (Updated June 8, 2011, 9:51 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > Hello, > = > the method removeDirectory wasn't removing the parent folder. = > For example,if we named out plasmoid my_plasmoid it would have a director= y like this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/m= y_plasmoid" and the after calling the removeDirectory(before the patch) met= hod we would have a directory like this: > ""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES". > With the patch the entire folder my_plasmoid is being deleted. > = > = > Diffs > ----- > = > projectmanager/projectmanager.cpp c00fd27 = > = > Diff: http://git.reviewboard.kde.org/r/101550/diff > = > = > Testing > ------- > = > compiles without issues and without regressions. > = > = > Thanks, > = > Giorgos > = > --===============6981142963581860824== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101550/

= =

projectmanager/projectmanager.cpp (Diff revision 1)
void ProjectManager::removeDirectory(const QString& path) =
		173	d.cdUp();
		174	QString rmNotes =3D &quo= t;NOTES";
		175	d.remove(rmNotes);
		176	QString rootPath =3D d.path();
		177	d.rmdir(rootPath);

please use KIO::del here (defined in KIO/DeleteJob)

it simplifies everything and uses KIO as it should be...

- Aaron J.

On June 8th, 2011, 9:51 p.m., Giorgos Tsiapaliwkas wrote:

Review request for Plasma.

By Giorgos Tsiapaliwkas.

Updated June 8, 2011, 9:51 p.m.

Descripti= on

Hello,

the method removeDirectory wasn't removing the parent folder. =

For example,if we named out plasmoid my_plasmoid it would have a directory =
like this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoi=
d/my_plasmoid" and the after calling the removeDirectory(before the pa=
tch) method we would have a directory like this:
""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NO=
TES".
With the patch the entire folder my_plasmoid is being deleted.

Testing <= /h1>

compiles without issues and without regressions.

Diffs=

projectmanager/projectmanager.cpp (c00fd27= )

--===============6981142963581860824==-- --===============1588964573== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1588964573==--