--===============0817628719== Content-Type: multipart/alternative; boundary="===============8101685618488110453==" --===============8101685618488110453== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101543/#review4039 ----------------------------------------------------------- it looks good except for one spot that changes behaviour (comment inline be= low) plasma/containments/newspaper/appletscontainer.cpp this is not equivalent. it means that if there is no containment, calli= ng setExpandAll will do nothing, not even record the expected setting. - Aaron J. On June 8, 2011, 1:23 p.m., Aleix Pol Gonzalez wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101543/ > ----------------------------------------------------------- > = > (Updated June 8, 2011, 1:23 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > While tracking down some problems in the Newspaper containment problems I= decided to simplify a little its code. I think this makes it a little more= readable. > = > Hope that helps. > = > = > Diffs > ----- > = > plasma/containments/newspaper/appletscontainer.cpp 1ba4d83 = > = > Diff: http://git.reviewboard.kde.org/r/101543/diff > = > = > Testing > ------- > = > = > Thanks, > = > Aleix > = > --===============8101685618488110453== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101543/

it looks g=
ood except for one spot that changes behaviour (comment inline below)

= = = = = =

plasma/containments/newspaper/appletscontainer.cpp (Diff revision 1)
void AppletsContainer::updateSize()
188	if (m_expandAll =3D=3D expand) {	184	if (m_expandAll =3D=3D expand \|\| !m_containment) {
189	return;	185	return;
190	}	186	}
191		187
192	m_expandAll =3D expand;<= /span>	188	m_expandAll =3D expand;<= /span>
193		189
194	if (!m_containment) {
195	return;
196	}
197

this is not equivalent. it means that if there is no containment, ca=
lling setExpandAll will do nothing, not even record the expected setting.

- Aaron J.

On June 8th, 2011, 1:23 p.m., Aleix Pol Gonzalez wrote:

Review request for Plasma.

By Aleix Pol Gonzalez.

Updated June 8, 2011, 1:23 p.m.

Descripti= on

While tracking down some problems in the Newspaper containme=
nt problems I decided to simplify a little its code. I think this makes it =
a little more readable.

Hope that helps.

Diffs=

plasma/containments/newspaper/appletscontainer.cpp (1ba4d83)

--===============8101685618488110453==-- --===============0817628719== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0817628719==--