| This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101543/ |
it looks good except for one spot that changes behaviour (comment inline below)
| plasma/containments/newspaper/appletscontainer.cpp (Diff revision 1) | |||
|---|---|---|---|
void AppletsContainer::updateSize() |
|||
| 188 | if (m_expandAll == expand) { |
184 | if (m_expandAll == expand || !m_containment) { |
| 189 | return; |
185 | return; |
| 190 | } |
186 | } |
| 191 | 187 | ||
| 192 | m_expandAll = expand; |
188 | m_expandAll = expand; |
| 193 | 189 | ||
| 194 | if (!m_containment) { |
||
| 195 | return; |
||
| 196 | } |
||
| 197 | |||
this is not equivalent. it means that if there is no containment, calling setExpandAll will do nothing, not even record the expected setting.
- Aaron J.
On June 8th, 2011, 1:23 p.m., Aleix Pol Gonzalez wrote:
|
Review request for Plasma.
By Aleix Pol Gonzalez.
Updated June 8, 2011, 1:23 p.m. Description
Diffs
|