'Re: Review Request: Enable per event icons in KNotify'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Enable per event icons in KNotify
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2011-05-29 21:48:22
Message-ID: 20110529214822.3112.89779 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101470/#review3583
-----------------------------------------------------------

Ship it!

great; backwards compatible, and forwards looking. commit!

- Aaron J.

On May 29, 2011, 8:44 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101470/
> -----------------------------------------------------------
> 
> (Updated May 29, 2011, 8:44 p.m.)
> 
> 
> Review request for KDE Runtime and Plasma.
> 
> 
> Summary
> -------
> 
> This patch enables to specify different icon for every event in notifyrc file. Example:
>  [Event/telepathyError]
>  IconName=dialog-error
> 
>  [Event/telepathyInfo]
>  IconName=dialog-information
> 
> If there's no such key in [Event/..] section, it looks for the icon in [Global].
> 
> 
> Diffs
> -----
> 
>   knotify/notifybypopup.cpp 36c3039 
> 
> Diff: http://git.reviewboard.kde.org/r/101470/diff
> 
> 
> Testing
> -------
> 
> Testing was done by afiestas at #kde-devel. Works ok.
> 
> 
> Thanks,
> 
> Martin
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101470/">http://git.reviewboard.kde.org/r/101470/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">great; backwards \
compatible, and forwards looking. commit!</pre>  <br />

<p>- Aaron J.</p>

<br />
<p>On May 29th, 2011, 8:44 p.m., Martin Klapetek wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Runtime and Plasma.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated May 29, 2011, 8:44 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch enables to specify different icon for every event in notifyrc \
file. Example:  [Event/telepathyError]
 IconName=dialog-error

 [Event/telepathyInfo]
 IconName=dialog-information

If there&#39;s no such key in [Event/..] section, it looks for the icon in \
[Global].</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing was done by afiestas at #kde-devel. Works ok.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>knotify/notifybypopup.cpp <span style="color: grey">(36c3039)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101470/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 