--===============0164372464== Content-Type: multipart/alternative; boundary="===============4939027880637237336==" --===============4939027880637237336== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101411/#review3519 ----------------------------------------------------------- No, not implemented in Bespin - couldn't come up with a fancy solution :-( - Thomas On May 21, 2011, 7:30 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101411/ > ----------------------------------------------------------- > = > (Updated May 21, 2011, 7:30 p.m.) > = > = > Review request for kwin and Plasma. > = > = > Summary > ------- > = > This patch removes the drawbound functionality for moving/resizing window= s. Drawbound was/is a feature to only render an outline while resizing/movi= ng the window. It was a solution for the case that it is too slow to let th= e client update all the time and the geometry change is moved to the end of= the operation. > = > With compositing we have for quite some time already the resize effect to= replace the drawbound (given that the outline is extremly ugly and IIRC al= so broken for compositing), so it was only used when using no compositing b= ut makes the code rather complex and did rather ugly things (grabbing X ser= ver, using X drawing functionality, requiring an event filter). So I think = it is justified to remove this functionality for legacy system. Any objecti= ons? > = > This also removes the possibility for decorations to take over drawbound.= Given lxr no decoration is actually using it (b2 implements the method bu= t the code is ifdefed). I marked the method as deprecated and adjusted the = documentation. @Thomas: do you use it in Bespin? > = > I also removed the options from the KCM. We might consider adding a new o= ption to control the resize effect (though I don't want to touch that code = as it doesn't use ui files). I could not remove the rules rows from the rul= es KCM as my qt-designer currently crashes while starting :-( > = > Of course this is for when master is open to feature requests. > = > = > Adding Plasma as it removes functionality for legacy systems and I want a= complete workspace decision. > = > = > Diffs > ----- > = > kwin/activation.cpp b43f6ab = > kwin/client.h 3b42c29 = > kwin/client.cpp f4988ff = > kwin/geometry.cpp 499db65 = > kwin/kcmkwin/kwinoptions/windows.h dd2b619 = > kwin/kcmkwin/kwinoptions/windows.cpp 10b7579 = > kwin/kcmkwin/kwinrules/ruleswidget.h 6972e52 = > kwin/kcmkwin/kwinrules/ruleswidget.cpp 300191e = > kwin/libkdecorations/kdecoration.h 12612bc = > kwin/options.h 0ef0b92 = > kwin/options.cpp a4cee3c = > kwin/rules.h 84a8df1 = > kwin/rules.cpp 1587064 = > kwin/useractions.cpp d969def = > kwin/workspace.h 837e557 = > = > Diff: http://git.reviewboard.kde.org/r/101411/diff > = > = > Testing > ------- > = > Resizing/Moving still working with both compositing and no-compositing. > = > = > Thanks, > = > Martin > = > --===============4939027880637237336== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101411/ |
No, not im= plemented in Bespin - couldn't come up with a fancy solution :-(
- Thomas
On May 21st, 2011, 7:30 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
Review request for kwin and Plasma.
By Martin Gr=C3=A4=C3=9Flin.
Updated May 21, 2011, 7:30 p.m. Descripti= on
Testing <= /h1>
Diffs=
|