This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101411/

No, not im=
plemented in Bespin - couldn't come up with a fancy solution :-(

- Thomas

On May 21st, 2011, 7:30 p.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin and Plasma.

By Martin Gr=C3=A4=C3=9Flin.

Updated May 21, 2011, 7:30 p.m.

Descripti= on

This patch removes the drawbound functionality for moving/re=
sizing windows. Drawbound was/is a feature to only render an outline while =
resizing/moving the window. It was a solution for the case that it is too s=
low to let the client update all the time and the geometry change is moved =
to the end of the operation.

With compositing we have for quite some time already the resize effect to r=
eplace the drawbound (given that the outline is extremly ugly and IIRC also=
 broken for compositing), so it was only used when using no compositing but=
 makes the code rather complex and did rather ugly things (grabbing X serve=
r, using X drawing functionality, requiring an event filter). So I think it=
 is justified to remove this functionality for legacy system. Any objection=
s?

This also removes the possibility for decorations to take over drawbound. G=
iven lxr no decoration is actually using it  (b2 implements the method but =
the code is ifdefed). I marked the method as deprecated and adjusted the do=
cumentation. @Thomas: do you use it in Bespin?

I also removed the options from the KCM. We might consider adding a new opt=
ion to control the resize effect (though I don't want to touch that cod=
e as it doesn't use ui files). I could not remove the rules rows from t=
he rules KCM as my qt-designer currently crashes while starting :-(

Of course this is for when master is open to feature requests.


Adding Plasma as it removes functionality for legacy systems and I want a c=
omplete workspace decision.

Testing <= /h1>

Resizing/Moving still working with both compositing and no-c=
ompositing.

Diffs=

kwin/activation.cpp (b43f6ab)
kwin/client.h (3b42c29)
kwin/client.cpp (f4988ff)
kwin/geometry.cpp (499db65)
kwin/kcmkwin/kwinoptions/windows.h (dd2b61= 9)
kwin/kcmkwin/kwinoptions/windows.cpp (10b7= 579)
kwin/kcmkwin/kwinrules/ruleswidget.h (6972= e52)
kwin/kcmkwin/kwinrules/ruleswidget.cpp (30= 0191e)
kwin/libkdecorations/kdecoration.h (12612b= c)
kwin/options.h (0ef0b92)
kwin/options.cpp (a4cee3c)
kwin/rules.h (84a8df1)
kwin/rules.cpp (1587064)
kwin/useractions.cpp (d969def)
kwin/workspace.h (837e557)

View Diff

Descripti= on

Testing <= /h1> Resizing/Moving still working with both compositing and no-c= ompositing.

Diffs=

Testing <= /h1>

Resizing/Moving still working with both compositing and no-c= ompositing.