'Review Request: Remove Mouse Emulation from KWin'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Remove Mouse Emulation from KWin
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2011-05-21 6:57:00
Message-ID: 20110521065700.9952.98682 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101406/
-----------------------------------------------------------

Review request for kwin and Plasma.

Summary
-------

Mouse Emulation is provided in a better way by KAccess. This provides a glo=
bal systemsettings switch to enable mouse emulation instead of a shortcut a=
nd Xkb to enable mouse control with keyboard instead of sending out fake mo=
use events.

So no need for duplicated functionality in KWin.

Feature for "when master opens up again"

Diffs
-----

  kwin/events.cpp 66a9419 =

  kwin/kwinbindings.cpp 06ed2e8 =

  kwin/workspace.h 837e557 =

  kwin/workspace.cpp cb73cc9 =

Diff: http://git.reviewboard.kde.org/r/101406/diff

Testing
-------

KWin compiles and starts

Thanks,

Martin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101406/">http://git.reviewboard.kde.org/r/101406/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Mouse Emulation is provided in a better way by KAccess. This provides a \
global systemsettings switch to enable mouse emulation instead of a shortcut and Xkb \
to enable mouse control with keyboard instead of sending out fake mouse events.

So no need for duplicated functionality in KWin.

Feature for &quot;when master opens up again&quot;</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KWin compiles and starts</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/events.cpp <span style="color: grey">(66a9419)</span></li>

 <li>kwin/kwinbindings.cpp <span style="color: grey">(06ed2e8)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(837e557)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(cb73cc9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101406/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 