--===============1010227947== Content-Type: multipart/alternative; boundary="===============0106155738127393081==" --===============0106155738127393081== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101367/#review3421 ----------------------------------------------------------- This review has been submitted with commit 37ca3f30d28ef2405f5cb41033f6bc0b= 96473ee5 by Martin Gr=C3=A4=C3=9Flin. - Commit On May 17, 2011, 5:10 p.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101367/ > ----------------------------------------------------------- > = > (Updated May 17, 2011, 5:10 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > As QPixmap::handle is not returning something useful if run with graphics= system raster, we need to check if the handle is valid. If not we need to c= reate an XPixmap, create a QPixmap from it (then handle returns useful info= ) and perform a deep copy of the pixmap's content. > = > = > Diffs > ----- > = > libs/plasmagenericshell/panelshadows.cpp 3a27992 = > = > Diff: http://git.reviewboard.kde.org/r/101367/diff > = > = > Testing > ------- > = > Shadows with Graphicssystem Raster: OK > = > Shadows with Graphicssystem Native: OK > = > = > Thanks, > = > Martin > = > --===============0106155738127393081== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101367/ 

This revie=
w has been submitted with commit 37ca3f30d28ef2405f5cb41033f6bc0b96473ee5 b=
y Martin Gr=C3=A4=C3=9Flin.

- Commit


On May 17th, 2011, 5:10 p.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for Plasma.
By Martin Gr=C3=A4=C3=9Flin.

Updated May 17, 2011, 5:10 p.m.

Descripti= on 

As QPixmap::handle is not returning something useful if run =
with graphicssystem raster, we need to check if the handle is valid. If not=
 we need to create an XPixmap, create a QPixmap from it (then handle return=
s useful info) and perform a deep copy of the pixmap's content.

Testing <= /h1> 
Shadows with Graphicssystem Raster: OK

Shadows with Graphicssystem Native: OK

Diffs=

  • libs/plasmagenericshell/panelshadows.cpp (= 3a27992)

View Diff
--===============0106155738127393081==-- --===============1010227947== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1010227947==--