From kde-panel-devel Fri May 20 10:58:12 2011 From: "Aaron J. Seigo" Date: Fri, 20 May 2011 10:58:12 +0000 To: kde-panel-devel Subject: Re: [kde-workspace/libplasma2] plasma/generic/applets/activitybar: Message-Id: <4857293.BbBqBBIdrL () freedom> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=130588915218237 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1191372477==" --===============1191372477== Content-Type: multipart/signed; boundary="nextPart4600888.UuIpkk5SV5"; micalg="pgp-sha1"; protocol="application/pgp-signature" Content-Transfer-Encoding: 7Bit --nextPart4600888.UuIpkk5SV5 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" taking this to plasma-devel ... On Friday, May 20, 2011 11:35:32 Marco Martin wrote: > On Friday 20 May 2011, Aaron Seigo wrote: > > Git commit 7dd83400f8fa5bdb1de180c90a29343064d027a3 by Aaron Seigo. > > Committed on 20/05/2011 at 10:23. > > Pushed by aseigo into branch 'libplasma2'. > > > > remove usage of Plasma/Context > > > > this means it probably does not work anymore with Plasma Netbook; will > > need to discuss what we wish to do about this with Marco. it was a 4.6 > > TODO for plasma-netbook, so may as well do it by now. > > > > CCMAIL:notmart@gmail.com > > my take at this point in time... > just make netbook support proper activities ;) while it's the immediate answer that came to me as well, i'm not sure it really makes much sense to do so. the pages of widgets aren't really activities they are, well, pages of widgets :) plasma-netbook knows what the list is and the name of each, it could just store that on its own. one way this could be done really easily is to have an internal DataEngine and use PluginLoader to deliver it. it could have the same API as the Activities one and then ActivityBar could do something like this: m_engine = dataEngine("org.kde.shellcontainments"); // or whatever if (!m_engine->isValid()) { m_engine = dataEngine("org.kde.activities"); } no code dupe in ActivityBar, and netbook could provide a very simple DataEngine for it to use. what do you think? > also, now some boilerplate code that does the coupling > containment(s)/activity has to be copied over and over in order to do so > (had to copy it in plasma- mobile) this could go as well in the portion of > plasmagenericshell worth of being public api probably makes sense, assuming we can come up with a sensible API that can be shared. did you simply copy classess from plasma-desktop over without any modifications? (e.g. Activity) > and finally, if the plasma mobile shell will have the panel as different > window now, there would be no reason to not use it for the netbook as well, > keeping containment/applets layout of the netbook shell of course with the same window switcher as well? what features of the mobile shell panel would you want in plasma netbook? (just so i understand better how much we could share :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks --nextPart4600888.UuIpkk5SV5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iEYEABECAAYFAk3WSUgACgkQ1rcusafx20NcHwCfcuLrx9LVuIcKFQWQkYGn5x/E rOUAmwV/NXOBTDSUEDgojq4mB2A4y4se =VTXZ -----END PGP SIGNATURE----- --nextPart4600888.UuIpkk5SV5-- --===============1191372477== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1191372477==--