This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101310/

Ship it!

fix the indentation and commit :)

mainwindow.cpp (Diff revision 2) 

   
void MainWindow::showStartPage()


  

 




 
 



 

  

    
    

    234
    
  toolBar()->hide();

  


  

    
    

    235
    
  menuBar()->hide();

  


  

    
    

    236
    
  setCentralWidget(m_central);

  


  

    
    

    237
    
  m_central->switchTo(m_startPage);

  


  

    
    

    238
    
  setDockOptions(QMainWindow::AllowNestedDocks);

  


 





needs to be indented 4 spaces









- Aaron J.






On May 10th, 2011, 3:08 p.m., Giorgos Tsiapaliwkas wrote:









 

  


Review request for Plasma.


By Giorgos Tsiapaliwkas.




Updated May 10, 2011, 3:08 p.m.






Description 



 

  
   
hello,

this patch adds a menu bar for startpage at file.(Go to file->startpage).The actual work is that using the startpage button the user is  able to go back to the startpage from the editor.

Unfortunately,there is a regression.If you go to start page using the startpage button when you will load a project from the recent list you will receive a sigsegment error.I think that the problem is located at the editors/edipage.cpp:line 152 (emit loadEditor(offers, path);).

thank you for your time. 

  		
 






Testing 



 

  
   
tseting done by me

  		
 








Diffs 


    

 
  • mainwindow.h (ea78e4d)
    • 

 
  • mainwindow.cpp (8d47b09)
    • 

 
  • plasmateui.rc (05aa1cd)
    • 





View Diff