From kde-panel-devel Fri May 20 10:04:48 2011 From: "Aaron J. Seigo" Date: Fri, 20 May 2011 10:04:48 +0000 To: kde-panel-devel Subject: Re: Review Request: plasmate:startpage menu bar added Message-Id: <20110520100448.18885.36431 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=130588592615143 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1454926672==" --===============1454926672== Content-Type: multipart/alternative; boundary="===============7329997818429593710==" --===============7329997818429593710== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101310/#review3416 ----------------------------------------------------------- Ship it! fix the indentation and commit :) mainwindow.cpp needs to be indented 4 spaces - Aaron J. On May 10, 2011, 3:08 p.m., Giorgos Tsiapaliwkas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101310/ > ----------------------------------------------------------- > = > (Updated May 10, 2011, 3:08 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > hello, > = > this patch adds a menu bar for startpage at file.(Go to file->startpage).= The actual work is that using the startpage button the user is able to go = back to the startpage from the editor. > = > Unfortunately,there is a regression.If you go to start page using the sta= rtpage button when you will load a project from the recent list you will re= ceive a sigsegment error.I think that the problem is located at the editors= /edipage.cpp:line 152 (emit loadEditor(offers, path);). > = > thank you for your time. = > = > = > Diffs > ----- > = > mainwindow.h ea78e4d = > mainwindow.cpp 8d47b09 = > plasmateui.rc 05aa1cd = > = > Diff: http://git.reviewboard.kde.org/r/101310/diff > = > = > Testing > ------- > = > tseting done by me > = > = > Thanks, > = > Giorgos > = > --===============7329997818429593710== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101310/

Ship it!

fix the in=
dentation and commit :)

= =
mainwindow.cpp (Diff revision 2) 

   
void MainWindow::showStartPage()


  

 

  

    
    

    234
    
  toolBar()->hide=
();

  


  

    
    

    235
    
  menuBar()->hide=
();

  


  

    
    

    236
    
  setCentralWidget(m_central=
);

  


  

    
    

    237
    
  m_central->switchTo(m_startPage);

  


  

    
    

    238
    
  setDockOptions(QMainWindow=
::AllowNestedDocks);

  


 





needs to be indented 4 spaces









- Aaron J.






On May 10th, 2011, 3:08 p.m., Giorgos Tsiapaliwkas wrote:









 

  


Review request for Plasma.


By Giorgos Tsiapaliwkas.




Updated May 10, 2011, 3:08 p.m.






Descripti=
on 



 

  
   
hello,

this patch adds a menu bar for startpage at file.(Go to file->startpage)=
.The actual work is that using the startpage button the user is  able to go=
 back to the startpage from the editor.

Unfortunately,there is a regression.If you go to start page using the start=
page button when you will load a project from the recent list you will rece=
ive a sigsegment error.I think that the problem is located at the editors/e=
dipage.cpp:line 152 (emit loadEditor(offers, path);).

thank you for your time. 

  		
 






Testing <=
/h1>


 

  
   
tseting done by me

  		
 








Diffs=
 


    

 
  • mainwindow.h (ea78e4d)
    • 

 
  • mainwindow.cpp (8d47b09)
    • 

 
  • plasmateui.rc (05aa1cd)
    • 





View Diff





  		
 











  

 



--===============7329997818429593710==--

--===============1454926672==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============1454926672==--