'Re: Review Request: Fix Panel Shadow when Plasma is using'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix Panel Shadow when Plasma is using
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2011-05-15 7:29:47
Message-ID: 20110515072947.5103.58093 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101367/
-----------------------------------------------------------

(Updated May 15, 2011, 7:29 a.m.)

Review request for Plasma.

Changes
-------

Fix include

Summary
-------

As QPixmap::handle is not returning something useful if run with graphicssy=
stem raster, we need to check if the handle is valid. If not we need to cre=
ate an XPixmap, create a QPixmap from it (then handle returns useful info) =
and perform a deep copy of the pixmap's content.

Diffs (updated)
-----

  libs/plasmagenericshell/panelshadows.cpp 3a27992 =

Diff: http://git.reviewboard.kde.org/r/101367/diff

Testing
-------

Shadows with Graphicssystem Raster: OK

Shadows with Graphicssystem Native: OK

Thanks,

Martin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101367/">http://git.reviewboard.kde.org/r/101367/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated May 15, 2011, 7:29 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix include</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As QPixmap::handle is not returning something useful if run with \
graphicssystem raster, we need to check if the handle is valid. If not we need to \
create an XPixmap, create a QPixmap from it (then handle returns useful info) and \
perform a deep copy of the pixmap&#39;s content.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Shadows with Graphicssystem Raster: OK

Shadows with Graphicssystem Native: OK</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/plasmagenericshell/panelshadows.cpp <span style="color: \
grey">(3a27992)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101367/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 