[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix build of libkdeclarative with ENABLE_FINAL.
From: "Nicolas Alvarez" <nicolas.alvarez () gmail ! com>
Date: 2011-05-08 21:29:33
Message-ID: 20110508212933.22593.54535 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 4, 2011, 10:05 a.m., Aaron J. Seigo wrote:
> > looks fine, though i'd prefer not using underscores (something we avoid=
in the coding style :)
Underscores removed, submitted in http://commits.kde.org/kdelibs/525afb748a=
8906518a0c913b39abe826a8673c01
(The review didn't get auto-closed on push because git hooks were temporari=
ly broken)
- Nicolas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101278/#review3101
-----------------------------------------------------------
On May 2, 2011, 10:21 p.m., Nicolas Alvarez wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101278/
> -----------------------------------------------------------
> =
> (Updated May 2, 2011, 10:21 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> kdelibs compilation is broken with KDE4_ENABLE_FINAL turned ON. One of th=
e problems is in libkdeclarative, where there's two file-static functions w=
ith the same name (ctor) and different code. These functions are used as fu=
nction pointers when creating the QScript function objects.
> =
> Fixed by renaming the two functions to icon_ctor and url_ctor.
> =
> =
> Diffs
> -----
> =
> experimental/libkdeclarative/bindings/icon.cpp 24885fa9d55b01388c681ec1=
766b659474fc40d7 =
> experimental/libkdeclarative/bindings/url.cpp 21c7aa2227ea4ee10a1523990=
5553bab40687fc5 =
> =
> Diff: http://git.reviewboard.kde.org/r/101278/diff
> =
> =
> Testing
> -------
> =
> Compilation of kdelibs with and without final. Didn't try installing or r=
unning.
> =
> =
> Thanks,
> =
> Nicolas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101278/">http://git.reviewboard.kde.org/r/101278/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 4th, 2011, 10:05 a.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">looks fine, though i'd prefer not using underscores (something we \
avoid in the coding style :)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Underscores removed, \
submitted in http://commits.kde.org/kdelibs/525afb748a8906518a0c913b39abe826a8673c01
(The review didn't get auto-closed on push because git hooks were temporarily \
broken)</pre> <br />
<p>- Nicolas</p>
<br />
<p>On May 2nd, 2011, 10:21 p.m., Nicolas Alvarez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Nicolas Alvarez.</div>
<p style="color: grey;"><i>Updated May 2, 2011, 10:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kdelibs compilation is broken with KDE4_ENABLE_FINAL turned ON. One of \
the problems is in libkdeclarative, where there's two file-static functions with \
the same name (ctor) and different code. These functions are used as function \
pointers when creating the QScript function objects.
Fixed by renaming the two functions to icon_ctor and url_ctor.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compilation of kdelibs with and without final. Didn't try installing \
or running.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>experimental/libkdeclarative/bindings/icon.cpp <span style="color: \
grey">(24885fa9d55b01388c681ec1766b659474fc40d7)</span></li>
<li>experimental/libkdeclarative/bindings/url.cpp <span style="color: \
grey">(21c7aa2227ea4ee10a15239905553bab40687fc5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101278/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic