[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: plasmate:"more projects" renamed to ..
From: "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date: 2011-05-10 14:11:19
Message-ID: 20110510141119.31639.6329 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 6, 2011, 6:54 p.m., Giorgos Tsiapaliwkas wrote:
> > should i push the new diff?
>
> Aaron J. Seigo wrote:
> yes; when it's marked with ShipIt you can push. sometimes there are some additional \
> comments, but those are going to be detail items at that point, and you don't need \
> to re-submit the diff before pushing :)
sorry for my late respawn but i was busy with a greek foss event.
Actually there is an issue with the patch.If i add 5 projects and then delete them \
all from the list,plasmate will still think that i have 5 projects because plasmate \
counts the projects that are located in "~/.kde/share/apps/plasmate" directory.
Remember that we had discussed,about a destroy button which will delete the projects \
from the list and from the system.
what should i do?
- Giorgos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101243/#review3175
-----------------------------------------------------------
On April 28, 2011, 6:54 p.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101243/
> -----------------------------------------------------------
>
> (Updated April 28, 2011, 6:54 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> hello,
>
> the patch renames the "more projects" to "manage projects" if the projects are 0>= \
> and <=4 and renames it to "manage and more project" for >5.
> We decided to make this patch after a discussion at the plasma-devel with aseigo.
>
> p.s.:i have git access i just need my patch to be reviewed.
>
>
> Diffs
> -----
>
> startpage.cpp c29f85f
>
> Diff: http://git.reviewboard.kde.org/r/101243/diff
>
>
> Testing
> -------
>
> compiled and worked,with no issues.
>
>
> Thanks,
>
> Giorgos
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101243/">http://git.reviewboard.kde.org/r/101243/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 6th, 2011, 6:54 p.m., <b>Giorgos \
Tsiapaliwkas</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">should i push the new diff?</pre> </blockquote>
<p>On May 6th, 2011, 8:26 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes; when it's \
marked with ShipIt you can push. sometimes there are some additional comments, but \
those are going to be detail items at that point, and you don't need to re-submit \
the diff before pushing :)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sorry for my late \
respawn but i was busy with a greek foss event.
Actually there is an issue with the patch.If i add 5 projects and then delete them \
all from the list,plasmate will still think that i have 5 projects because plasmate \
counts the projects that are located in "~/.kde/share/apps/plasmate" \
directory.
Remember that we had discussed,about a destroy button which will delete the projects \
from the list and from the system.
what should i do?</pre>
<br />
<p>- Giorgos</p>
<br />
<p>On April 28th, 2011, 6:54 p.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated April 28, 2011, 6:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hello,
the patch renames the "more projects" to "manage projects" if the \
projects are 0>= and <=4 and renames it to "manage and more project" \
for >5.
We decided to make this patch after a discussion at the plasma-devel with aseigo.
p.s.:i have git access i just need my patch to be reviewed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiled and worked,with no issues.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>startpage.cpp <span style="color: grey">(c29f85f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101243/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic