[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: plasmate:startpage menu bar added
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-05-06 20:50:11
Message-ID: 20110506205011.5203.92740 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 6, 2011, 7 p.m., Shaun Reich wrote:
> > mainwindow.cpp, line 214
> > <http://git.reviewboard.kde.org/r/101310/diff/1/?file=16257#file16257line214>
> >
> > "Startpage" -> "Start Page" (2 words)
i'd go as far as to suggest "Return to Start Page", or even just "Close Project"
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101310/#review3174
-----------------------------------------------------------
On May 6, 2011, 6:36 p.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101310/
> -----------------------------------------------------------
>
> (Updated May 6, 2011, 6:36 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> hello,
>
> this patch adds a menu bar for startpage at file.(Go to file->startpage).The actual \
> work is that using the startpage button the user is able to go back to the \
> startpage from the editor.
> Unfortunately,there is a regression.If you go to start page using the startpage \
> button when you will load a project from the recent list you will receive a \
> sigsegment error.I think that the problem is located at the \
> editors/edipage.cpp:line 152 (emit loadEditor(offers, path);).
> thank you for your time.
>
>
> Diffs
> -----
>
> mainwindow.h ea78e4d
> mainwindow.cpp bb241a0
> plasmateui.rc 05aa1cd
>
> Diff: http://git.reviewboard.kde.org/r/101310/diff
>
>
> Testing
> -------
>
> tseting done by me
>
>
> Thanks,
>
> Giorgos
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101310/">http://git.reviewboard.kde.org/r/101310/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 6th, 2011, 7 p.m., <b>Shaun Reich</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101310/diff/1/?file=16257#file16257line214" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mainwindow.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KAction *MainWindow::addAction(QString text, const char * icon, const char *slot, \
const char *name, const KShortcut &shortcut)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">214</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">214</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">addAction</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span class="s">"Startpage"</span><span \
class="p">),</span> <span class="s">"plasmagik"</span><span \
class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span \
class="n">go_startpage</span><span class="p">()),</span> <span \
class="s">"startpage"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"Startpage" \
-> "Start Page" (2 words)</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i'd go \
as far as to suggest "Return to Start Page", or even just "Close \
Project"</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On May 6th, 2011, 6:36 p.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated May 6, 2011, 6:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hello,
this patch adds a menu bar for startpage at file.(Go to file->startpage).The \
actual work is that using the startpage button the user is able to go back to the \
startpage from the editor.
Unfortunately,there is a regression.If you go to start page using the startpage \
button when you will load a project from the recent list you will receive a \
sigsegment error.I think that the problem is located at the editors/edipage.cpp:line \
152 (emit loadEditor(offers, path);).
thank you for your time. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tseting done by me</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mainwindow.h <span style="color: grey">(ea78e4d)</span></li>
<li>mainwindow.cpp <span style="color: grey">(bb241a0)</span></li>
<li>plasmateui.rc <span style="color: grey">(05aa1cd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101310/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic