'Review Request: plasmate:startpage menu bar added'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: plasmate:startpage menu bar added
From:       "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date:       2011-05-06 18:36:36
Message-ID: 20110506183636.31254.34806 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101310/
-----------------------------------------------------------

Review request for Plasma.

Summary
-------

hello,

this patch adds a menu bar for startpage at file.(Go to file->startpage).Th=
e actual work is that using the startpage button the user is  able to go ba=
ck to the startpage from the editor.

Unfortunately,there is a regression.If you go to start page using the start=
page button when you will load a project from the recent list you will rece=
ive a sigsegment error.I think that the problem is located at the editors/e=
dipage.cpp:line 152 (emit loadEditor(offers, path);).

thank you for your time. =

Diffs
-----

  mainwindow.h ea78e4d =

  mainwindow.cpp bb241a0 =

  plasmateui.rc 05aa1cd =

Diff: http://git.reviewboard.kde.org/r/101310/diff

Testing
-------

tseting done by me

Thanks,

Giorgos

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101310/">http://git.reviewboard.kde.org/r/101310/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hello,

this patch adds a menu bar for startpage at file.(Go to file-&gt;startpage).The \
actual work is that using the startpage button the user is  able to go back to the \
startpage from the editor.

Unfortunately,there is a regression.If you go to start page using the startpage \
button when you will load a project from the recent list you will receive a \
sigsegment error.I think that the problem is located at the editors/edipage.cpp:line \
152 (emit loadEditor(offers, path);).

thank you for your time. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tseting done by me</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>mainwindow.h <span style="color: grey">(ea78e4d)</span></li>

 <li>mainwindow.cpp <span style="color: grey">(bb241a0)</span></li>

 <li>plasmateui.rc <span style="color: grey">(05aa1cd)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101310/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 