[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Don't create another timeline on every timeout
From: "Alexey Chernov" <4ernov () gmail ! com>
Date: 2011-05-01 20:47:13
Message-ID: 20110501204713.1341.81433 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 1, 2011, 8:07 p.m., Marco Martin wrote:
> >
Thank you. Committed it.
- Alexey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101212/#review3021
-----------------------------------------------------------
On May 1, 2011, 5:39 p.m., Alexey Chernov wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101212/
> -----------------------------------------------------------
> =
> (Updated May 1, 2011, 5:39 p.m.)
> =
> =
> Review request for Plasma and Aaron J. Seigo.
> =
> =
> Summary
> -------
> =
> Currently RTM plasmoid creates new timeline on every refresh triggered by=
timeout (usually 5 minutes) of any action with tasks. Timeline is somethin=
g like user session and every user action can be undone while still staying=
in the same timeline (http://www.rememberthemilk.com/services/api/timeline=
s.rtm). I think, creating a new timeline on every refresh isn't so wise, es=
pecially as it triggeres the massive update of all the tasks and lists.
> =
> =
> Diffs
> -----
> =
> dataengines/rememberthemilk/taskssource.cpp 06d354f9a6facfe8dc1ba426830=
78ab02ff39900 =
> =
> Diff: http://git.reviewboard.kde.org/r/101212/diff
> =
> =
> Testing
> -------
> =
> The comment to the line of code says: "Allow us to get new information th=
at people entered on the website or in another api". I tested the version w=
ithout the line quite deeply performing task edits in both RTM web service =
and plasmoid and they were always synchronized with each other correctly (f=
or plasmoid - as current timeout expired). So I see no reason in this.
> =
> =
> Thanks,
> =
> Alexey
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101212/">http://git.reviewboard.kde.org/r/101212/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you. Committed \
it.</pre> <br />
<p>- Alexey</p>
<br />
<p>On May 1st, 2011, 5:39 p.m., Alexey Chernov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Alexey Chernov.</div>
<p style="color: grey;"><i>Updated May 1, 2011, 5:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently RTM plasmoid creates new timeline on every refresh triggered \
by timeout (usually 5 minutes) of any action with tasks. Timeline is something like \
user session and every user action can be undone while still staying in the same \
timeline (http://www.rememberthemilk.com/services/api/timelines.rtm). I think, \
creating a new timeline on every refresh isn't so wise, especially as it \
triggeres the massive update of all the tasks and lists.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The comment to the line of code says: "Allow us to get new \
information that people entered on the website or in another api". I tested the \
version without the line quite deeply performing task edits in both RTM web service \
and plasmoid and they were always synchronized with each other correctly (for \
plasmoid - as current timeout expired). So I see no reason in this.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/rememberthemilk/taskssource.cpp <span style="color: \
grey">(06d354f9a6facfe8dc1ba42683078ab02ff39900)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101212/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic