[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: Simplify WallpaperRenderer threading
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-04-30 11:32:50
Message-ID: 20110430113250.26481.33026 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101257/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
Wallpaper threading simplified. Threads are not reused and pointers are not passed around.
Please ignore the changes to AbstractRunner and Corona; post-review is being odd.
This addresses bug 272032.
http://bugs.kde.org/show_bug.cgi?id=272032
Diffs
-----
plasma/abstractrunner.cpp 6c56ea1e938b0a3213d68735e8f7debff18f0fd1
plasma/corona.cpp 826cec4930b71f016319aa92a3855e9581fe0d88
plasma/private/wallpaper_p.h 383feb1f72f3416f3ffbcb4df5fb78fb5576881e
plasma/private/wallpaperrenderthread.cpp e18e683218b9a9446ebafefdaf87264e05dbbd6c
plasma/private/wallpaperrenderthread_p.h 81e46031d866e3aa50c45b5331015b969ed8a1ae
plasma/wallpaper.h 7af17afe492fd728537091c8c2bd919c3cd2a96e
plasma/wallpaper.cpp b3675ae5439470a56956ea50d3751ffdb55945b7
Diff: http://git.reviewboard.kde.org/r/101257/diff
Testing
-------
Thanks,
Aaron J.
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101257/">http://git.reviewboard.kde.org/r/101257/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aaron J. Seigo.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Wallpaper threading simplified. Threads are not reused and pointers are \
not passed around.
Please ignore the changes to AbstractRunner and Corona; post-review is being \
odd.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=272032">272032</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/abstractrunner.cpp <span style="color: \
grey">(6c56ea1e938b0a3213d68735e8f7debff18f0fd1)</span></li>
<li>plasma/corona.cpp <span style="color: \
grey">(826cec4930b71f016319aa92a3855e9581fe0d88)</span></li>
<li>plasma/private/wallpaper_p.h <span style="color: \
grey">(383feb1f72f3416f3ffbcb4df5fb78fb5576881e)</span></li>
<li>plasma/private/wallpaperrenderthread.cpp <span style="color: \
grey">(e18e683218b9a9446ebafefdaf87264e05dbbd6c)</span></li>
<li>plasma/private/wallpaperrenderthread_p.h <span style="color: \
grey">(81e46031d866e3aa50c45b5331015b969ed8a1ae)</span></li>
<li>plasma/wallpaper.h <span style="color: \
grey">(7af17afe492fd728537091c8c2bd919c3cd2a96e)</span></li>
<li>plasma/wallpaper.cpp <span style="color: \
grey">(b3675ae5439470a56956ea50d3751ffdb55945b7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101257/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic