[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Check for new comic strips
From: "Matthias Fuchs" <mat69 () gmx ! net>
Date: 2011-04-30 10:33:47
Message-ID: 20110430103347.21172.45211 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101252/
-----------------------------------------------------------
(Updated April 30, 2011, 10:33 a.m.)
Review request for Plasma and Aaron J. Seigo.
Changes
-------
Adds action to jump to the next tab with a new comic strip.
NOTE: The shortcut is not working, what can I do to fix that?
Btw. I'll look into the highlight tab stuff now.
Summary
-------
Checks if there a new comic strips for the chosen comics. The user can defi=
ne a time intervall in minutes for that.
If a new comic strip is found, then the tab is "highlighted" by prepending =
a "*" to the tab text.
First I planned to change the tab text color but this is not possible, unle=
ss the NativeTabBar code would change.
But I think the way it is now works reasonable well.
Diffs (updated)
-----
applets/comic/CMakeLists.txt b85cb33 =
applets/comic/checknewstrips.h PRE-CREATION =
applets/comic/checknewstrips.cpp PRE-CREATION =
applets/comic/comic.h ca55959 =
applets/comic/comic.cpp 814cca8 =
applets/comic/comicSettings.ui f7fdeed =
applets/comic/comicarchivejob.cpp 33d1da4 =
applets/comic/configwidget.h 767dc3d =
applets/comic/configwidget.cpp 0dfd9ab =
applets/comic/imagewidget.cpp 15e1ddb =
dataengines/comic/comicprovider.cpp 73f1791 =
Diff: http://git.reviewboard.kde.org/r/101252/diff
Testing
-------
Screenshots
-----------
http://git.reviewboard.kde.org/r/101252/s/142/
http://git.reviewboard.kde.org/r/101252/s/143/
Thanks,
Matthias
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101252/">http://git.reviewboard.kde.org/r/101252/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Matthias Fuchs.</div>
<p style="color: grey;"><i>Updated April 30, 2011, 10:33 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds action to jump to the next tab with a new comic strip.
NOTE: The shortcut is not working, what can I do to fix that?
Btw. I'll look into the highlight tab stuff now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Checks if there a new comic strips for the chosen comics. The user can \
define a time intervall in minutes for that. If a new comic strip is found, then the \
tab is "highlighted" by prepending a "*" to the tab text. First I \
planned to change the tab text color but this is not possible, unless the \
NativeTabBar code would change. But I think the way it is now works reasonable \
well.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>applets/comic/CMakeLists.txt <span style="color: grey">(b85cb33)</span></li>
<li>applets/comic/checknewstrips.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/comic/checknewstrips.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/comic/comic.h <span style="color: grey">(ca55959)</span></li>
<li>applets/comic/comic.cpp <span style="color: grey">(814cca8)</span></li>
<li>applets/comic/comicSettings.ui <span style="color: grey">(f7fdeed)</span></li>
<li>applets/comic/comicarchivejob.cpp <span style="color: \
grey">(33d1da4)</span></li>
<li>applets/comic/configwidget.h <span style="color: grey">(767dc3d)</span></li>
<li>applets/comic/configwidget.cpp <span style="color: grey">(0dfd9ab)</span></li>
<li>applets/comic/imagewidget.cpp <span style="color: grey">(15e1ddb)</span></li>
<li>dataengines/comic/comicprovider.cpp <span style="color: \
grey">(73f1791)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101252/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101252/s/142/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/04/29/comic_new_strip1_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/101252/s/143/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/04/29/comic_new_strip2_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic