[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Preconfigurable plasmoids
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-04-28 21:19:33
Message-ID: 20110428211933.32358.4300 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101251/#review2950
-----------------------------------------------------------
an interesting idea, but the configuration values should not appear in the =
metadata.desktop file. it not only bloats up the # of keys we have, it does=
n't scale to plasmoids with more/different configuration.
i think this would make more sense as a .desktop + a KConfigGroup (could ev=
en be in the same file?) that holds the complete default configuration that=
is then copied over after the applet is created.
- Aaron J.
On April 28, 2011, 8:30 p.m., David Palacio wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101251/
> -----------------------------------------------------------
> =
> (Updated April 28, 2011, 8:30 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> There is some code duplication in that some plasmoids share very much of =
program logic but actually differ in just a setting. E.g. the recently made=
ShowActivityManager plasmoid, which just is a DBus call launcher. The Icon=
plasmoid is an example of this made right. I'd like to have more generic p=
lasmoids. Even better, I'd like to have an easy way to configure them. =
=
=
=
> =
=
=
> Let's see the code. config.patch shows a way to load a config metadata fi=
le and fill a designated plasmoid with the configuration data (metadata.des=
ktop). We search for a X-Plasma-ConfigApplet property that defines the plas=
moid to configure and load. Additional properties define the plasmoid setti=
ngs. This allows us, for example, to easily provide access to any webservic=
e without code duplication. =
=
=
> =
> =
> Diffs
> -----
> =
> plasma/data/servicetypes/plasma-applet.desktop 8fabddb =
> plasma/pluginloader.cpp e57cac5 =
> =
> Diff: http://git.reviewboard.kde.org/r/101251/diff
> =
> =
> Testing
> -------
> =
> Loading of plasmoids works.
> Configuration is not correctly being feed to plasmoids.
> =
> =
> Thanks,
> =
> David
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101251/">http://git.reviewboard.kde.org/r/101251/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">an interesting idea, but \
the configuration values should not appear in the metadata.desktop file. it not only \
bloats up the # of keys we have, it doesn't scale to plasmoids with \
more/different configuration.
i think this would make more sense as a .desktop + a KConfigGroup (could even be in \
the same file?) that holds the complete default configuration that is then copied \
over after the applet is created.</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On April 28th, 2011, 8:30 p.m., David Palacio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Palacio.</div>
<p style="color: grey;"><i>Updated April 28, 2011, 8:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There is some code duplication in that some plasmoids share very much of \
program logic but actually differ in just a setting. E.g. the recently made \
ShowActivityManager plasmoid, which just is a DBus call launcher. The Icon plasmoid \
is an example of this made right. I'd like to have more generic plasmoids. Even \
better, I'd like to have an easy way to configure them. \
Let's see the code. config.patch shows a way to load a config metadata file and \
fill a designated plasmoid with the configuration data (metadata.desktop). We search \
for a X-Plasma-ConfigApplet property that defines the plasmoid to configure and load. \
Additional properties define the plasmoid settings. This allows us, for example, to \
easily provide access to any webservice without code duplication. \
</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Loading of plasmoids works. Configuration is not correctly being feed to \
plasmoids. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/data/servicetypes/plasma-applet.desktop <span style="color: \
grey">(8fabddb)</span></li>
<li>plasma/pluginloader.cpp <span style="color: grey">(e57cac5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101251/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic