'Re: Review Request: plasmate:"more projects" renamed to ..'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: plasmate:"more projects" renamed to ..
From:       "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date:       2011-04-28 18:54:29
Message-ID: 20110428185429.15052.87276 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101243/
-----------------------------------------------------------

(Updated April 28, 2011, 6:54 p.m.)

Review request for Plasma.

Changes
-------

coding changes

Summary
-------

hello,

the patch renames the "more projects" to "manage projects" if the projects are 0>= \
and <=4 and renames it to "manage and more project" for >5.

We decided to make this patch after a discussion at the plasma-devel with aseigo.

p.s.:i have git access i just need my patch to be reviewed.

Diffs (updated)
-----

  startpage.cpp c29f85f 

Diff: http://git.reviewboard.kde.org/r/101243/diff

Testing
-------

compiled and worked,with no issues.

Thanks,

Giorgos

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101243/">http://git.reviewboard.kde.org/r/101243/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>

<p style="color: grey;"><i>Updated April 28, 2011, 6:54 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">coding changes</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hello,

the patch renames the &quot;more projects&quot; to &quot;manage projects&quot; if the \
projects are 0&gt;= and &lt;=4 and renames it to &quot;manage and more project&quot; \
for &gt;5.

We decided to make this patch after a discussion at the plasma-devel with aseigo.

p.s.:i have git access i just need my patch to be reviewed.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiled and worked,with no issues.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>startpage.cpp <span style="color: grey">(c29f85f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101243/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 