'Review Request: Supports creation of Comic Book Archives'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Supports creation of Comic Book Archives
From:       "Matthias Fuchs" <mat69 () gmx ! net>
Date:       2011-04-26 9:47:48
Message-ID: 20110426094748.10820.70431 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101235/
-----------------------------------------------------------

Review request for Plasma and Aaron J. Seigo.

Summary
-------

Adds possiblity to create a Comic Book Archive (.cbz) for a range: All, Beg=
inTo, EndTo, Range

The job is displayed using the global job tracker, though atm. I have not i=
mplemented the total number of files that have to be downloaded, since that=
 is more complicated. I might do that later.

There is one thing I don't understand. How do I set an error that the job t=
racker ui will also display it? The way I am setting the error apparntly di=
d not result in the plasma job ui tracker to display it.

Diffs
-----

  applets/comic/CMakeLists.txt 8513d9c =

  applets/comic/comic.h 7134c72 =

  applets/comic/comic.cpp 88a2e31 =

  applets/comic/comicarchivedialog.h PRE-CREATION =

  applets/comic/comicarchivedialog.cpp PRE-CREATION =

  applets/comic/comicarchivedialog.ui PRE-CREATION =

  applets/comic/comicarchivejob.h PRE-CREATION =

  applets/comic/comicarchivejob.cpp PRE-CREATION =

  dataengines/comic/comicprovider.cpp 73f1791 =

Diff: http://git.reviewboard.kde.org/r/101235/diff

Testing
-------

Thanks,

Matthias

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101235/">http://git.reviewboard.kde.org/r/101235/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Matthias Fuchs.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds possiblity to create a Comic Book Archive (.cbz) for a range: All, \
BeginTo, EndTo, Range

The job is displayed using the global job tracker, though atm. I have not implemented \
the total number of files that have to be downloaded, since that is more complicated. \
I might do that later.

There is one thing I don&#39;t understand. How do I set an error that the job tracker \
ui will also display it? The way I am setting the error apparntly did not result in \
the plasma job ui tracker to display it.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/comic/CMakeLists.txt <span style="color: grey">(8513d9c)</span></li>

 <li>applets/comic/comic.h <span style="color: grey">(7134c72)</span></li>

 <li>applets/comic/comic.cpp <span style="color: grey">(88a2e31)</span></li>

 <li>applets/comic/comicarchivedialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/comic/comicarchivedialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/comic/comicarchivedialog.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/comic/comicarchivejob.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>applets/comic/comicarchivejob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>dataengines/comic/comicprovider.cpp <span style="color: \
grey">(73f1791)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101235/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 