[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: Add "Icons" item to desktop theme details GUI
From: "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date: 2011-04-22 13:09:34
Message-ID: 20110422130934.13203.31951 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101175/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
The "System Settings - Workspace Appearance - Desktop Theme - Details" dial=
ogue allows individual theme elements to be selected from any of the availa=
ble desktop themes. However, there is no GUI option to select a theme's ic=
ons - those stored in the theme's 'icons/' subdirectory and used in the sys=
tem tray. None of the standard KDE themes provide their own icons - they a=
ll use the default ones from Air - but some themes on kde-look do.
This 1-line patch adds an "Icons" item to this dialogue. Selecting and cop=
ying the icons from a theme is all automatically handled in DesktopThemeDet=
ails::save() with no additional code changes being necessary.
Diffs
-----
kcontrol/desktoptheme/desktopthemedetails.cpp 4daced9 =
Diff: http://git.reviewboard.kde.org/r/101175/diff
Testing
-------
Built kde-workspace with these changes, checked operation of dialogue and t=
hat theme icons are correctly copied to user's $KDEDIR/share/apps/desktopth=
eme/.customized/icons.
Thanks,
Jonathan
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101175/">http://git.reviewboard.kde.org/r/101175/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jonathan Marten.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The "System Settings - Workspace Appearance - Desktop Theme - \
Details" dialogue allows individual theme elements to be selected from any of \
the available desktop themes. However, there is no GUI option to select a \
theme's icons - those stored in the theme's 'icons/' subdirectory and \
used in the system tray. None of the standard KDE themes provide their own icons - \
they all use the default ones from Air - but some themes on kde-look do.
This 1-line patch adds an "Icons" item to this dialogue. Selecting and \
copying the icons from a theme is all automatically handled in \
DesktopThemeDetails::save() with no additional code changes being necessary.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built kde-workspace with these changes, checked operation of dialogue \
and that theme icons are correctly copied to user's \
$KDEDIR/share/apps/desktoptheme/.customized/icons. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/desktoptheme/desktopthemedetails.cpp <span style="color: \
grey">(4daced9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101175/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic