[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix bug197654: do not save config again when Apply
From: "Commit Hook" <null () kde ! org>
Date: 2011-04-21 14:43:52
Message-ID: 20110421144352.19366.15125 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101159/#review2806
-----------------------------------------------------------
This review has been submitted with commit 805544113d8ce4d8580776070126f1d747b1ee5a \
by Aaron Seigo.
- Commit
On April 21, 2011, 8:40 a.m., Max Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101159/
> -----------------------------------------------------------
>
> (Updated April 21, 2011, 8:40 a.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Ignore save config again after click Ok button when Apply button disabled. On \
> Desktop Settings dialog with Slideshow mode, the image would not change again when \
> we click Ok button after we clicked Apply button.
>
> This addresses bug 197654.
> http://bugs.kde.org/show_bug.cgi?id=197654
>
>
> Diffs
> -----
>
> libs/plasmagenericshell/backgrounddialog.cpp 53ac05a
>
> Diff: http://git.reviewboard.kde.org/r/101159/diff
>
>
> Testing
> -------
>
> It's works fine on my machine.
>
>
> Thanks,
>
> Max
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101159/">http://git.reviewboard.kde.org/r/101159/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 805544113d8ce4d8580776070126f1d747b1ee5a by Aaron Seigo.</pre> \
<br />
<p>- Commit</p>
<br />
<p>On April 21st, 2011, 8:40 a.m., Max Lin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Max Lin.</div>
<p style="color: grey;"><i>Updated April 21, 2011, 8:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ignore save config again after click Ok button when Apply button \
disabled. On Desktop Settings dialog with Slideshow mode, the image would not change \
again when we click Ok button after we clicked Apply button. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It's works fine on my machine.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=197654">197654</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmagenericshell/backgrounddialog.cpp <span style="color: \
grey">(53ac05a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101159/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic