[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add option to qalculate to show the result in
From: "Commit Hook" <null () kde ! org>
Date: 2011-04-19 13:06:11
Message-ID: 20110419130611.19973.34666 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100533/#review2751
-----------------------------------------------------------
This review has been submitted with commit ff3ca7928615f91bacb23b7cf449f25d=
022b2521 by Matteo Agostinelli.
- Commit
On March 9, 2011, 8:34 a.m., Jef Steelant wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100533/
> -----------------------------------------------------------
> =
> (Updated March 9, 2011, 8:34 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Add the option to qalculate to show the result in binary, octal, decimal =
and hexadecimal at the same time.
> This only works if the result is an integer
> =
> =
> Diffs
> -----
> =
> applets/qalculate/qalculate_engine.cpp 708f3b2 =
> applets/qalculate/qalculate_labels.h 4cf31e2 =
> applets/qalculate/qalculate_labels.cpp b04c538 =
> applets/qalculate/qalculate_settings.h c696b0a =
> applets/qalculate/qalculate_settings.cpp 97c0c01 =
> =
> Diff: http://git.reviewboard.kde.org/r/100533/diff
> =
> =
> Testing
> -------
> =
> built and tested the applet
> =
> =
> Screenshots
> -----------
> =
> settings
> http://git.reviewboard.kde.org/r/100533/s/63/
> result
> http://git.reviewboard.kde.org/r/100533/s/64/
> =
> =
> Thanks,
> =
> Jef
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100533/">http://git.reviewboard.kde.org/r/100533/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit ff3ca7928615f91bacb23b7cf449f25d022b2521 by Matteo \
Agostinelli.</pre> <br />
<p>- Commit</p>
<br />
<p>On March 9th, 2011, 8:34 a.m., Jef Steelant wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jef Steelant.</div>
<p style="color: grey;"><i>Updated March 9, 2011, 8:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add the option to qalculate to show the result in binary, octal, decimal \
and hexadecimal at the same time. This only works if the result is an integer</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">built and tested the applet</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/qalculate/qalculate_engine.cpp <span style="color: \
grey">(708f3b2)</span></li>
<li>applets/qalculate/qalculate_labels.h <span style="color: \
grey">(4cf31e2)</span></li>
<li>applets/qalculate/qalculate_labels.cpp <span style="color: \
grey">(b04c538)</span></li>
<li>applets/qalculate/qalculate_settings.h <span style="color: \
grey">(c696b0a)</span></li>
<li>applets/qalculate/qalculate_settings.cpp <span style="color: \
grey">(97c0c01)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100533/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100533/s/63/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/03/settings_400x100.png" \
style="border: 1px black solid;" alt="settings" /></a>
<a href="http://git.reviewboard.kde.org/r/100533/s/64/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/03/result_400x100.png" \
style="border: 1px black solid;" alt="result" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic