[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix plasma locale problems with multihead
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2011-04-16 13:48:08
Message-ID: 20110416134808.13767.83220 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 16, 2011, 10:06 a.m., Christoph Feck wrote:
> > Compilation fails with this error:
> >
> > kde-workspace/plasma/desktop/shell/plasmaapp.cpp:119:59: error: taking address of \
> > temporary
>
> Alberto Mattea wrote:
> Weird, it works without problems here. I've seen aseigo has done further changes to \
> this code. Maybe try again with latest git?
Thanks, Aaron's changes fixed it. The error is new as of gcc 4.6, that's probably \
why it worked for you.
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101133/#review2676
-----------------------------------------------------------
On April 15, 2011, 2:09 p.m., Alberto Mattea wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101133/
> -----------------------------------------------------------
>
> (Updated April 15, 2011, 2:09 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This small patch fixes locale problems with plasma multihead. Currently the shell \
> on secondary screens is in English regardless of what is set in the preferences.
>
> This addresses bug 156475.
> http://bugs.kde.org/show_bug.cgi?id=156475
>
>
> Diffs
> -----
>
> plasma/desktop/shell/main.cpp 0faf351
> plasma/desktop/shell/plasmaapp.cpp 86c6bfb
>
> Diff: http://git.reviewboard.kde.org/r/101133/diff
>
>
> Testing
> -------
>
> It works here (for italian).
>
>
> Thanks,
>
> Alberto
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101133/">http://git.reviewboard.kde.org/r/101133/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 16th, 2011, 10:06 a.m., <b>Christoph \
Feck</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compilation fails with this error:
kde-workspace/plasma/desktop/shell/plasmaapp.cpp:119:59: error: taking address of \
temporary</pre> </blockquote>
<p>On April 16th, 2011, 11:37 a.m., <b>Alberto Mattea</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Weird, it works without \
problems here. I've seen aseigo has done further changes to this code. Maybe try \
again with latest git?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks, Aaron's \
changes fixed it. The error is new as of gcc 4.6, that's probably why it worked \
for you.</pre> <br />
<p>- Christoph</p>
<br />
<p>On April 15th, 2011, 2:09 p.m., Alberto Mattea wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Alberto Mattea.</div>
<p style="color: grey;"><i>Updated April 15, 2011, 2:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This small patch fixes locale problems with plasma multihead. Currently \
the shell on secondary screens is in English regardless of what is set in the \
preferences.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works here (for italian).</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=156475">156475</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/main.cpp <span style="color: grey">(0faf351)</span></li>
<li>plasma/desktop/shell/plasmaapp.cpp <span style="color: \
grey">(86c6bfb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101133/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic