'Re: Review Request: Kinda fixes "memory leak" caused by comic plasmoid'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Kinda fixes "memory leak" caused by comic plasmoid
From:       "Commit Hook" <null () kde ! org>
Date:       2011-04-15 9:50:46
Message-ID: 20110415095046.11661.41290 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101046/#review2656
-----------------------------------------------------------

This review has been submitted with commit ae06eee1733655d408b2ec6cca0b783f=
94df7e82 by Matthias Fuchs.

- Commit

On April 7, 2011, 3:46 p.m., Matthias Fuchs wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101046/
> -----------------------------------------------------------
> =

> (Updated April 7, 2011, 3:46 p.m.)
> =

> =

> Review request for Plasma and Aaron J. Seigo.
> =

> =

> Summary
> -------
> =

> The comic plasmoid uses prefetching by calling Plasma::DataEngine::query(=
source).
> Yet apparantly these created sources do not get removed automatically (?)=
 causing an increase of memory usage the more comics are viewed.
> =

> E.g. looking at 15 strips of Lackadaisy that had not been cached before c=
aused a memory usage of 114 MB for the plasmoidviewer. The patch reduces th=
e usage in the same case to 52.9 MB. Each of these comics has a size betwee=
n 1.2 MB and 2.6 MB.
> So please comment on the patch! :)
> =

> I wonder why it is still that high with the patch after looking at some c=
omics, so if you can help to reduce that further that would be great.
> Further I wonder if some of the perceived "plasma mem leak" reports are c=
aused by the way the comic plasmoid works.
> =

> =

> Diffs
> -----
> =

>   applets/comic/comic.cpp 3785f4f =

>   dataengines/comic/comic.cpp 09bbafd =

> =

> Diff: http://git.reviewboard.kde.org/r/101046/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Matthias
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101046/">http://git.reviewboard.kde.org/r/101046/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit ae06eee1733655d408b2ec6cca0b783f94df7e82 by Matthias \
Fuchs.</pre>  <br />

<p>- Commit</p>

<br />
<p>On April 7th, 2011, 3:46 p.m., Matthias Fuchs wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Matthias Fuchs.</div>

<p style="color: grey;"><i>Updated April 7, 2011, 3:46 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The comic plasmoid uses prefetching by calling \
Plasma::DataEngine::query(source). Yet apparantly these created sources do not get \
removed automatically (?) causing an increase of memory usage the more comics are \
viewed.

E.g. looking at 15 strips of Lackadaisy that had not been cached before caused a \
memory usage of 114 MB for the plasmoidviewer. The patch reduces the usage in the \
same case to 52.9 MB. Each of these comics has a size between 1.2 MB and 2.6 MB. So \
please comment on the patch! :)

I wonder why it is still that high with the patch after looking at some comics, so if \
you can help to reduce that further that would be great. Further I wonder if some of \
the perceived &quot;plasma mem leak&quot; reports are caused by the way the comic \
plasmoid works.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/comic/comic.cpp <span style="color: grey">(3785f4f)</span></li>

 <li>dataengines/comic/comic.cpp <span style="color: grey">(09bbafd)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101046/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 