'Re: Review Request: changing statement import Qt 4.7 to import'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: changing statement import Qt 4.7 to import
From:       "Commit Hook" <sysadmin () kde ! org>
Date:       2011-04-13 12:57:23
Message-ID: 20110413125723.29373.50040 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101110/#review2612
-----------------------------------------------------------

This review has been submitted with commit c1d156748baaaa3cff67b4008aa204ba=
b3681b4c by Sinny Kumari.

- Commit

On April 13, 2011, 5:08 a.m., Sinny Kumari wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101110/
> -----------------------------------------------------------
> =

> (Updated April 13, 2011, 5:08 a.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Summary
> -------
> =

> This patch changes import statement from  import Qt 4.7 to import QtQuick=
 1.0  as it is recommended in Qt Documentation.
> =

> =

> Diffs
> -----
> =

>   templates/mainPlasmoid.qml b499004 =

> =

> Diff: http://git.reviewboard.kde.org/r/101110/diff
> =

> =

> Testing
> -------
> =

> works fine
> =

> =

> Thanks,
> =

> Sinny
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101110/">http://git.reviewboard.kde.org/r/101110/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit c1d156748baaaa3cff67b4008aa204bab3681b4c by Sinny Kumari.</pre> \
<br />

<p>- Commit</p>

<br />
<p>On April 13th, 2011, 5:08 a.m., Sinny Kumari wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Sinny Kumari.</div>

<p style="color: grey;"><i>Updated April 13, 2011, 5:08 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch changes import statement from  import Qt 4.7 to import \
QtQuick 1.0  as it is recommended in Qt Documentation.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works fine</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>templates/mainPlasmoid.qml <span style="color: grey">(b499004)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101110/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 