[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: DeclarativeImports-DataSource: Add the name of the
From: "Anton Kreuzkamp" <akreuzkamp () web ! de>
Date: 2011-04-11 14:34:25
Message-ID: 20110411143425.28026.79256 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 11, 2011, 11:33 a.m., Marco Martin wrote:
> > are you sure the property binding still works?
> > ime, even if the qt doc about it isn't clear at all, any signal set as =
NOTIFY of some qproperty does seem to work only if doesn't have any paramet=
er
> =
> Anton Kreuzkamp wrote:
> ah, not quite sure, I just know that onDataChanged gets invoked corre=
ctly and I can access the property.
> What is the NOTIFY exactly needed for?
> =
> Marco Martin wrote:
> if for instance you have
> Item {
> width: 200
> Item {
> width: parent.width
> }
> }
> =
> the width of the child item will be correctly updated when the width =
of the parent item changes, that sync is done with the NOTIFY signal (see p=
roperty bindings in the qml docs)
Sorry, that I didn't express clear enough.
I know that. What I meant was "What is the NOTIFY exactly needed for regard=
ing to data/dataChanged()?"
- Anton
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101081/#review2554
-----------------------------------------------------------
On April 11, 2011, 10:56 a.m., Anton Kreuzkamp wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101081/
> -----------------------------------------------------------
> =
> (Updated April 11, 2011, 10:56 a.m.)
> =
> =
> Review request for Plasma and Marco Martin.
> =
> =
> Summary
> -------
> =
> Add the name of the changed source as parameter to the dataChanged() sign=
al in the qml DataSource class.
> This eases up the qml-code massively and improves the performance, as I d=
on't need to update all sources anymore, when just one source changes.
> =
> =
> Diffs
> -----
> =
> plasma/declarativeimports/core/datasource.cpp 0cd5a73 =
> plasma/declarativeimports/core/datasource_p.h 2d2cb13 =
> =
> Diff: http://git.reviewboard.kde.org/r/101081/diff
> =
> =
> Testing
> -------
> =
> Works.
> =
> =
> Thanks,
> =
> Anton
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101081/">http://git.reviewboard.kde.org/r/101081/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 11th, 2011, 11:33 a.m., <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">are you sure the property binding still works? ime, even if the qt doc \
about it isn't clear at all, any signal set as NOTIFY of some qproperty does seem \
to work only if doesn't have any parameter</pre> </blockquote>
<p>On April 11th, 2011, 2 p.m., <b>Anton Kreuzkamp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ah, not quite sure, I \
just know that onDataChanged gets invoked correctly and I can access the property. \
What is the NOTIFY exactly needed for?</pre> </blockquote>
<p>On April 11th, 2011, 2:22 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">if for instance you have \
Item { width: 200
Item {
width: parent.width
}
}
the width of the child item will be correctly updated when the width of the parent \
item changes, that sync is done with the NOTIFY signal (see property bindings in the \
qml docs)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, that I didn't \
express clear enough. I know that. What I meant was "What is the NOTIFY exactly \
needed for regarding to data/dataChanged()?"</pre> <br />
<p>- Anton</p>
<br />
<p>On April 11th, 2011, 10:56 a.m., Anton Kreuzkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Anton Kreuzkamp.</div>
<p style="color: grey;"><i>Updated April 11, 2011, 10:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add the name of the changed source as parameter to the dataChanged() \
signal in the qml DataSource class. This eases up the qml-code massively and improves \
the performance, as I don't need to update all sources anymore, when just one \
source changes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/core/datasource.cpp <span style="color: \
grey">(0cd5a73)</span></li>
<li>plasma/declarativeimports/core/datasource_p.h <span style="color: \
grey">(2d2cb13)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101081/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic