This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100919/

Ship it!

since as we talked, a proper solution that should replace unredirectfullscreen is being developed, i'm in favour of killing it in the netbook

- Marco


On March 22nd, 2011, 5:31 p.m., Martin Gräßlin wrote:

Review request for kwin, Plasma and Marco Martin.
By Martin Gräßlin.

Updated March 22, 2011, 5:31 p.m.

Description

Today a colleague at work did a presentation with Plasma Netbook Shell and I noticed some flickering. This can hopefully be solved by disabling unredirect fullscreen windows. Unredirect Fullscreen Windows is more or less useless for the formfactor netbook as you do not use it to
a) play OpenGL games
b) watch HD videos

Therefore I think it's the best to just disable it by default. (I'm also thinking about switching the default for desktop).

I think this patch would make sense to be backported to 4.6 or KDE/4.6 or foo/bar/4.6 or whatever the current naming scheme is. Maybe this would require a kconf update script, though.

Testing

it compiles :-)

Diffs

  • kcontrol/workspaceoptions/workspaceoptions.cpp (834a5dd)

View Diff