[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Disable Unredirect Fullscreen Windows in Netbook Shell
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2011-03-22 17:31:08
Message-ID: 20110322173108.23702.5447 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100919/
-----------------------------------------------------------

Review request for kwin, Plasma and Marco Martin.


Summary
-------

Today a colleague at work did a presentation with Plasma Netbook Shell and =
I noticed some flickering. This can hopefully be solved by disabling unredi=
rect fullscreen windows. Unredirect Fullscreen Windows is more or less usel=
ess for the formfactor netbook as you do not use it to
a) play OpenGL games
b) watch HD videos

Therefore I think it's the best to just disable it by default. (I'm also th=
inking about switching the default for desktop).

I think this patch would make sense to be backported to 4.6 or KDE/4.6 or f=
oo/bar/4.6 or whatever the current naming scheme is. Maybe this would requi=
re a kconf update script, though.


Diffs
-----

  kcontrol/workspaceoptions/workspaceoptions.cpp 834a5dd =


Diff: http://git.reviewboard.kde.org/r/100919/diff


Testing
-------

it compiles :-)


Thanks,

Martin


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100919/">http://git.reviewboard.kde.org/r/100919/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Plasma and Marco Martin.</div>
<div>By Martin Gräßlin.</div>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Today a colleague at work did a presentation with Plasma Netbook Shell \
and I noticed some flickering. This can hopefully be solved by disabling unredirect \
fullscreen windows. Unredirect Fullscreen Windows is more or less useless for the \
formfactor netbook as you do not use it to a) play OpenGL games
b) watch HD videos

Therefore I think it&#39;s the best to just disable it by default. (I&#39;m also \
thinking about switching the default for desktop).

I think this patch would make sense to be backported to 4.6 or KDE/4.6 or foo/bar/4.6 \
or whatever the current naming scheme is. Maybe this would require a kconf update \
script, though.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it compiles :-)</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcontrol/workspaceoptions/workspaceoptions.cpp <span style="color: \
grey">(834a5dd)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100919/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic