[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: KDevelop sessions runner
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2011-03-22 9:56:37
Message-ID: 20110322095637.31318.67841 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100903/
-----------------------------------------------------------
(Updated March 22, 2011, 9:56 a.m.)
Review request for Plasma.
Changes
-------
All comments have been addressed, prepare() and teardown() are now used.
Summary
-------
New KRunner plugin listing kdevelop sessions. Based on the same code for ka=
te, only changed the reading of the sessions.
Diffs (updated)
-----
dataengines/kdecommits/plasma-engine-kdecommits.desktop 73125b1 =
runners/CMakeLists.txt 7bcb05f =
runners/kdevelopsessions/CMakeLists.txt PRE-CREATION =
runners/kdevelopsessions/Messages.sh PRE-CREATION =
runners/kdevelopsessions/README PRE-CREATION =
runners/kdevelopsessions/kdevelopsessions.cpp PRE-CREATION =
runners/kdevelopsessions/kdevelopsessions.desktop PRE-CREATION =
runners/kdevelopsessions/kdevelopsessions.h PRE-CREATION =
Diff: http://git.reviewboard.kde.org/r/100903/diff
Testing
-------
Started different sessions of kdevelop from KRunner, works just fine.
Thanks,
Sebastian
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100903/">http://git.reviewboard.kde.org/r/100903/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated March 22, 2011, 9:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All comments have been addressed, prepare() and teardown() are now \
used.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">New KRunner plugin listing kdevelop sessions. Based on the same code for \
kate, only changed the reading of the sessions.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Started different sessions of kdevelop from KRunner, works just \
fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/kdecommits/plasma-engine-kdecommits.desktop <span style="color: \
grey">(73125b1)</span></li>
<li>runners/CMakeLists.txt <span style="color: grey">(7bcb05f)</span></li>
<li>runners/kdevelopsessions/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/kdevelopsessions/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/kdevelopsessions/README <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/kdevelopsessions/kdevelopsessions.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/kdevelopsessions/kdevelopsessions.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/kdevelopsessions/kdevelopsessions.h <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100903/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic