[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Adding "Set Wallpaper Image" option in Picture
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-03-17 13:25:09
Message-ID: 20110317132509.6931.64179 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100764/#review2012
-----------------------------------------------------------
Ship it!
looks good; one small crash prevention issue, and then please commit :)
applets/frame/frame.cpp
<http://git.reviewboard.kde.org/r/100764/#comment1683>
possibly crashable if the containment doesn't have a wallpaper; a separ=
ate variable probably isn't needed for this. just:
=
if (containment()->wallpaper() &&
containment()->wallpaper()->supportsMimetype(KMimeType::findByUrl(u=
rl)->name()) {
- Aaron J.
On March 3, 2011, 6:56 p.m., Sinny Kumari wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100764/
> -----------------------------------------------------------
> =
> (Updated March 3, 2011, 6:56 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Adding "Set Wallpaper Image" feature in Picture Frame. If the User right =
clicks on Picture Frame, there will be an option "Set Wallpaper Image". Thi=
s Option will set the current Image Of Picture Frame as Wallpaper Image. Do=
ne changes according to suggestion given by Todd and Aaron. Continuation of=
http://svn.reviewboard.kde.org/r/6416/.
> =
> =
> Diffs
> -----
> =
> applets/frame/frame.h bf7b95d =
> applets/frame/frame.cpp 871ebef =
> =
> Diff: http://git.reviewboard.kde.org/r/100764/diff
> =
> =
> Testing
> -------
> =
> working fine
> Added QTimer::singleShot(300,this, SLOT(setImageAsWallpaper())); line in=
frame.cpp because Plugin takes some time to load.
> Not sure it is correct way to do or not. Any suggestion?
> =
> =
> Thanks,
> =
> Sinny
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100764/">http://git.reviewboard.kde.org/r/100764/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good; one small \
crash prevention issue, and then please commit :)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/100764/diff/2/?file=10525#file10525line151" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/frame/frame.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void Frame::setImageAsWallpaper()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">151</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">bool</span> <span class="n">supports</span> <span class="o">=</span> <span \
class="n">containment</span><span class="p">()</span><span \
class="o">-></span><span class="n">wallpaper</span><span class="p">()</span><span \
class="o">-></span><span class="n">supportsMimetype</span><span \
class="p">(</span><span class="n">KMimeType</span><span class="o">::</span><span \
class="n">findByUrl</span><span class="p">(</span><span class="n">url</span><span \
class="p">).</span><span class="n">data</span><span class="p">()</span><span \
class="o">-></span><span class="n">name</span><span \
class="p">());</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">152</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">kDebug</span><span class="p">()</span> <span class="o"><<</span> \
<span class="n">supports</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">153</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">kDebug</span><span class="p">()</span> <span class="o"><<</span> \
<span class="n">KMimeType</span><span class="o">::</span><span \
class="n">findByUrl</span><span class="p">(</span><span class="n">url</span><span \
class="p">).</span><span class="n">data</span><span class="p">()</span><span \
class="o">-></span><span class="n">name</span><span \
class="p">();</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">154</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">155</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">supports</span><span \
class="p">)</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">possibly \
crashable if the containment doesn't have a wallpaper; a separate variable \
probably isn't needed for this. just:
if (containment()->wallpaper() &&
containment()->wallpaper()->supportsMimetype(KMimeType::findByUrl(url)->name()) \
{</pre> </div>
<br />
<p>- Aaron J.</p>
<br />
<p>On March 3rd, 2011, 6:56 p.m., Sinny Kumari wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sinny Kumari.</div>
<p style="color: grey;"><i>Updated March 3, 2011, 6:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding "Set Wallpaper Image" feature in Picture Frame. If the \
User right clicks on Picture Frame, there will be an option "Set Wallpaper \
Image". This Option will set the current Image Of Picture Frame as Wallpaper \
Image. Done changes according to suggestion given by Todd and Aaron. Continuation of \
http://svn.reviewboard.kde.org/r/6416/.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">working fine Added QTimer::singleShot(300,this, \
SLOT(setImageAsWallpaper())); line in frame.cpp because Plugin takes some time to \
load. Not sure it is correct way to do or not. Any suggestion?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/frame/frame.h <span style="color: grey">(bf7b95d)</span></li>
<li>applets/frame/frame.cpp <span style="color: grey">(871ebef)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100764/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic