[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Properly resize panel when screen resolution is
From: Yuen Hoe Lim <yuenhoe86 () gmail ! com>
Date: 2011-03-07 19:15:29
Message-ID: AANLkTinK9uOXs-GzfAJ8UJ7FuEb5n+X4yEpEm10o8w+P () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Yep, backported. Thanks for the link :)
----
Jason "moofang" Lim Yuen Hoe
http://yuenhoe.co.cc/
On Mon, Mar 7, 2011 at 8:47 PM, Sebastian K=FCgler <sebas@kde.org> wrote:
> On Saturday, March 05, 2011 11:12:39 Yuen Hoe Lim wrote:
> > > On March 5, 2011, 9:22 a.m., Aaron J. Seigo wrote:
> > > > nice fix; i have a feeling this code could be simplified somewhat,
> but
> > > > let's cover all the corner cases first.
> > > >
> > > > the issue you note about setting the size in a larger resolution an=
d
> > > > then switching back to a smaller one is an interesting one indeed.
> the
> > > > goal was (and i stress _was_, as we can alter this :) to allow
> > > > per-resolution panel settings. but as you note, that may not indeed
> be
> > > > what is wanted/expected all the time.
> > > >
> > > > for now, in terms of fixing this stuff up for 4.6.2, i don't think =
we
> > > > need to address it. but for 4.7 it might be nice to lay down some
> > > > arbitrary "rules" for panel sizing between resolution changes that
> > > > keeps some flexibility and obeys "least surprise" as much as possib=
le
> > > > and (re-?)write this code to match those rules.
> >
> > Thanks. Pushed to master. Umm, is there something else I need to do in
> > order for this to appear in 4.6.2?
>
> Yes, you need to backport it to the 4.6 branch, see
> http://techbase.kde.org/Development/Tutorials/Git/Recipes
>
> Cheers,
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
[Attachment #5 (text/html)]
Yep, backported. Thanks for the link :)<br clear="all">----<br>Jason \
"moofang" Lim Yuen Hoe<br><a \
href="http://yuenhoe.co.cc/">http://yuenhoe.co.cc/</a><br><br> <br><br><div \
class="gmail_quote">On Mon, Mar 7, 2011 at 8:47 PM, Sebastian Kügler <span \
dir="ltr"><<a href="mailto:sebas@kde.org">sebas@kde.org</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; \
border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> On Saturday, March \
05, 2011 11:12:39 Yuen Hoe Lim wrote:<br> <div class="im">> > On March 5, 2011, \
9:22 a.m., Aaron J. Seigo wrote:<br> > > > nice fix; i have a feeling this \
code could be simplified somewhat, but<br> > > > let's cover all the \
corner cases first.<br> > > ><br>
> > > the issue you note about setting the size in a larger resolution \
and<br> > > > then switching back to a smaller one is an interesting one \
indeed. the<br> > > > goal was (and i stress _was_, as we can alter this :) \
to allow<br> > > > per-resolution panel settings. but as you note, that may \
not indeed be<br> > > > what is wanted/expected all the time.<br>
> > ><br>
> > > for now, in terms of fixing this stuff up for 4.6.2, i don't think \
we<br> > > > need to address it. but for 4.7 it might be nice to lay down \
some<br> > > > arbitrary "rules" for panel sizing between \
resolution changes that<br> > > > keeps some flexibility and obeys \
"least surprise" as much as possible<br> > > > and (re-?)write \
this code to match those rules.<br> ><br>
> Thanks. Pushed to master. Umm, is there something else I need to do in<br>
> order for this to appear in 4.6.2?<br>
<br>
</div>Yes, you need to backport it to the 4.6 branch, see<br>
<a href="http://techbase.kde.org/Development/Tutorials/Git/Recipes" \
target="_blank">http://techbase.kde.org/Development/Tutorials/Git/Recipes</a><br> \
<br> Cheers,<br>
<font color="#888888">--<br>
sebas<br>
<br>
<a href="http://www.kde.org" target="_blank">http://www.kde.org</a> | <a \
href="http://vizZzion.org" target="_blank">http://vizZzion.org</a> | GPG Key ID: 9119 \
0EF9<br> </font><div><div></div><div \
class="h5">_______________________________________________<br> Plasma-devel mailing \
list<br> <a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
</div></div></blockquote></div><br>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic