[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add support for building libplasma with GLES2
From: Jammy Zhou <jammy.zhou () linaro ! org>
Date: 2011-03-01 1:29:13
Message-ID: AANLkTikwoOiw4E6EPaBi_0m5hgjBKijg5yC6=3USfk6m () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Sebas,
As Martin mentioned, the direct GL dependency has been removed in my new
patch, and the original "BUILD_PLASMA_WITH_OPENGLES" option I added is not
needed any more in this case.
Cheers,
Jammy
On Mon, Feb 28, 2011 at 11:33 PM, Martin Gr=E4=DFlin <mgraesslin@kde.org> w=
rote:
>
> ----- Urspr=FCngliche Mitteilung -----
> > On Friday, February 25, 2011 04:29:36 Jammy Zhou wrote:
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > http://git.reviewboard.kde.org/r/100705/
> > > -----------------------------------------------------------
> > > Update the patch to remove direct OpenGL dependency for libplasma. Th=
e
> > > OpenGL usage in libplasma should better go through libQtOpenGL,which
> > > can be enabled for desktop OpenGL or OpenGL ES2.0
> > >
> > > Summary
> > > -------
> > >
> > > After build kwin with GLES2 code path, the kwin binary still has
> > > dependency on libGL.so, which is introduced by libplasma.so. Then we
> > > also need to add GLES2 support to libplasma, so that kwin/plasma only
> > > has dependency on libGLESv2.so in this case.
> > >
> > > The new option "BUILD_PLASMA_WITH_OPENGLES" added in attached patch i=
s
> > > disabled by default, and distributions can turn it on when do packagi=
ng
> > > for OpenGL ES2.0 support.
> >
> > Shouldn't that option cover both, kwin and plasma? Or are there serious
> > cases where you'd want one, but not the other on opengl-es? If not,
> > let's merge them to prevent building and packaging headaches.
> First of all: the problem has been solved by removing the libGL dependenc=
y
> from libplasma.
>
> Now to the other question: yes there are cases for having kwin with gles
> and plasma with gl. kwin will start to focus on gles only (wayland) while
> there is no reason for Plasma to restrict on the gles api.
>
> Cheers
> Martin
> >
> > Cheers,
> > --
> > sebas
> >
> > http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
> > _______________________________________________
> > Plasma-devel mailing list
> > Plasma-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/plasma-devel
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
[Attachment #5 (text/html)]
Hi Sebas,<br><br>As Martin mentioned, the direct GL dependency has been removed in my \
new patch, and the original "BUILD_PLASMA_WITH_OPENGLES" option I added is \
not needed any more in this case.<br><br>Cheers,<br> Jammy<br><br><div \
class="gmail_quote">On Mon, Feb 28, 2011 at 11:33 PM, Martin Gräßlin <span \
dir="ltr"><<a href="mailto:mgraesslin@kde.org">mgraesslin@kde.org</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; \
border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <br>
----- Ursprüngliche Mitteilung -----<br>
<div><div></div><div class="h5">> On Friday, February 25, 2011 04:29:36 Jammy Zhou \
wrote:<br> > > -----------------------------------------------------------<br>
> > This is an automatically generated e-mail. To reply, visit:<br>
> > <a href="http://git.reviewboard.kde.org/r/100705/" \
target="_blank">http://git.reviewboard.kde.org/r/100705/</a><br> > > \
-----------------------------------------------------------<br> > > Update the \
patch to remove direct OpenGL dependency for libplasma. The<br> > > OpenGL \
usage in libplasma should better go through libQtOpenGL,which<br> > > can be \
enabled for desktop OpenGL or OpenGL ES2.0<br> > ><br>
> > Summary<br>
> > -------<br>
> ><br>
> > After build kwin with GLES2 code path, the kwin binary still has<br>
> > dependency on libGL.so, which is introduced by libplasma.so. Then we<br>
> > also need to add GLES2 support to libplasma, so that kwin/plasma only<br>
> > has dependency on libGLESv2.so in this case.<br>
> ><br>
> > The new option "BUILD_PLASMA_WITH_OPENGLES" added in attached \
patch is<br> > > disabled by default, and distributions can turn it on when do \
packaging<br> > > for OpenGL ES2.0 support.<br>
><br>
> Shouldn't that option cover both, kwin and plasma? Or are there serious<br>
> cases where you'd want one, but not the other on opengl-es? If not,<br>
> let's merge them to prevent building and packaging headaches.<br>
</div></div>First of all: the problem has been solved by removing the libGL \
dependency from libplasma.<br> <br>
Now to the other question: yes there are cases for having kwin with gles and plasma \
with gl. kwin will start to focus on gles only (wayland) while there is no reason for \
Plasma to restrict on the gles api.<br> <br>
Cheers<br>
Martin<br>
<div class="im">><br>
> Cheers,<br>
> --<br>
> sebas<br>
><br>
> <a href="http://www.kde.org" target="_blank">http://www.kde.org</a> | <a \
href="http://vizZzion.org" target="_blank">http://vizZzion.org</a> | GPG Key ID: 9119 \
0EF9<br> </div>> _______________________________________________<br>
> Plasma-devel mailing list<br>
> <a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
> <a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> <br>
_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
</blockquote></div><br>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic